1969753 - Let image.natural-size-fallback.enabled ride the trains

Status: VERIFIED FIXED

(Core :: Layout: Images, Video, and HTML Frames, task)

Description

[Daniel Holbert [:dholbert]]

With bug 1965560 fixed (I just triggered lando), we can let image.natural-size-fallback.enabled=true ride the trains to release (i.e. we can revert bug 1967844 and set the pref to true unconditionally).

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1969753: Let image.natural-size-fallback.enabled ride the trains (remove Nightly-only guard). r?#layout

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e79541aa0d47
https://hg.mozilla.org/integration/autoland/rev/1e346d51365e
Let image.natural-size-fallback.enabled ride the trains (remove Nightly-only guard). r=layout-reviewers,emilio

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/1e346d51365e

Comment 4

[Phabricator Automation]

firefox-esr140 Uplift Approval Request

• User impact if declined: This addresses WebCompat problems that otherwise cause breakage on icloud.com and several mapping apps (see the dependencies of bug 1965560), as some examples.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Fix can be validated by testing https://bugzilla.mozilla.org/show_bug.cgi?id=1951871

STR:

1. Visit https://findmybus.im/

Expected results: Blue bus icons on the map
Actual results (i.e. unfixed behavior): No bus icon

• Risk associated with taking this patch: low
• Explanation of risk level: This is sorta between Low and Medium. It's a behavior change in some "what size is this" APIs, and any behavior-change carries some risk. But the risk is manageable given that the new behavior is much closer to what other browsers have been shipping for a long time; and there are a bunch of new tests that I've added in supporting bugs; and this is controlled by a pref that folks can use to restore the old behavior if they happen to need it for some reason.
• String changes made/needed: None
• Is Android affected?: yes

Comment 5

[Daniel Holbert [:dholbert]]

Attachment: Bug 1969753: Let image.natural-size-fallback.enabled ride the trains (remove Nightly-only guard). r?#layout

Original Revision: https://phabricator.services.mozilla.com/D251994

Comment 6

[Daniel Holbert [:dholbert]]

Note to release managers: before we uplift this, we should first uplift these two stacks of test changes:

first: https://phabricator.services.mozilla.com/D267119 (and its stack)
second: https://phabricator.services.mozilla.com/D267123 (and its stack)

then, third, we can uplift this bug's own stack ( https://phabricator.services.mozilla.com/D251994 , which is this bug's patch plus the patches on bug 1965560)

(I tried to issue an uplift request for the whole thing as a stack, but Lando won't let me do that, since the web UI is limited to uplifts of patch-stacks with <=5 patches.)

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr140/rev/0d00ad1159e3

Comment 8

[Raluca Popovici, Desktop QA]

I was able to reproduce this issue on Nightly 141.0a1(2025-05-31) using Windows 11.
Verified as fixed on the latest Nightly 145.0a1(2025-10-01) and treeherder build 140.4.0esr using Windows 11, Mac 13.2.1, and Ubuntu 24.10. The blue bus icons are displayed on the map.