Closed Bug 1969880 Opened 1 year ago Closed 14 days ago

Clean up user context state when it's removed without WebDriver BiDi

Categories

(Remote Protocol :: WebDriver BiDi, task, P3)

Product:
Remote Protocol
Component:
WebDriver BiDi
Type:
task

Tracking

(firefox156 fixed)

Status:
RESOLVED FIXED
Milestone:
156 Branch
Tracking Flags:
Tracking Status
firefox156 --- fixed

People

(Reporter: Sasha, Assigned: sameembaba, Mentored)

References

(Blocks 1 open bug)

Details

(Whiteboard: [webdriver:m21][webdriver:external][lang=js])

Attachments

(1 file)

Bug 1969880 - Clean up WebDriver BiDi user context state when deleted externally. r=sasha
48 bytes, text/x-phabricator-request
Details | Review

With bug 1967653 and bug 1967653 we added the state when a user context is created. We clean up this state when "browser.removeUserContext" command is called, but if a user context is deleted outside of WebDriver BiDi we miss clearing it until the session is deleted. It shouldn't cause any direct issue, but still would nice to clean it up. For this, we probably could let the UserContextManager emit events when a user context is destroyed, and then the browser modules could run the cleanup steps.

Priority: -- → P3
Whiteboard: [webdriver:backlog]
Mentor: aborovova
Whiteboard: [webdriver:backlog] → [webdriver:backlog][lang=js]
Assignee: nobody → ssssameembaba
Status: NEW → ASSIGNED

https://hg.mozilla.org/mozilla-central/rev/27c805352a6c

Status: ASSIGNED → RESOLVED
Closed: 14 days ago
status-firefox156: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 156 Branch

Sameem, would bug 1958852 be a good candidate you might be interested in? It would be good to see those two sync modules merged.

Flags: needinfo?(ssssameembaba)
Whiteboard: [webdriver:backlog][lang=js] → [webdriver:m21][webdriver:external][lang=js]

Yeah, I can work on it.

Flags: needinfo?(ssssameembaba)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: