1969950 - Use JSOp::StrictConstantEq for default arguments

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Jan de Mooij [:jandem]]

It would be nice to use JSOp::StrictConstantEq for default function arguments such as function(x = 1) {}. We currently emit JSOp::Undefined followed by JSOp::StrictEq for this.

Comment 1

[Jan de Mooij [:jandem]]

js-perf-next: This should be a matter of emitting a different op in DefaultEmitter. We should also do a (quick) audit to see if there are other places where we emit StrictEq/StrictNe that could use the new op instead.

Comment 2

[Debadree Chatterjee]

Attachment: Bug 1969950: Use StrictConstantEq in undefined comparison in default arguments. r?jandem!

Comment 3

[Debadree Chatterjee]

Attachment: Bug 1969950: Replace StrictEq with ConstantStrictEq in emitSpreadArgumentsTest. r?jandem!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f50da362dd98
https://hg.mozilla.org/integration/autoland/rev/bef475eacfbf
Use StrictConstantEq in undefined comparison in default arguments. r=jandem
https://github.com/mozilla-firefox/firefox/commit/82ec33139322
https://hg.mozilla.org/integration/autoland/rev/b707ebd9af04
Replace StrictEq with ConstantStrictEq in emitSpreadArgumentsTest. r=jandem

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://github.com/mozilla-firefox/firefox/commit/f50da362dd989ddac29a00bb25cfd3d9e97fd0e5
https://hg.mozilla.org/mozilla-central/rev/bef475eacfbf
https://github.com/mozilla-firefox/firefox/commit/82ec331393220912862bc4c3cf065b79e398dd39
https://hg.mozilla.org/mozilla-central/rev/b707ebd9af04