1969980 - Remove 24 snackbars marked for removal

Status: RESOLVED FIXED

(Firefox for Android :: General, task)

Description

[:Gela]

Here is the original list of audited snackbars on Android for your reference: https://docs.google.com/spreadsheets/d/1CAcQY5z4tkMnwawIeMCzb8he6PHb21BFTSGlFBwLtTE/edit?gid=1571859094#gid=1571859094

Every snackbar (row in the doc) falls under one of the 3 categories: remove as is, update the existing snackbar, keep snackbar as is with no changes.

This ticket covers the removal of snackbar as determined. To make it simpler, I have created a copy of the same document but only included snackbars that can be removed without any design, string or UX changes:
https://docs.google.com/spreadsheets/d/1O4ZpxHOXFwhwNzpSQ4Sy2xtHqObRqjHD0550DRAV_o8/edit?usp=sharing

Comment 1

[:Gela]

Attachment: Bug 1969980 - part 1 - remove password saved and username updated snackbars

Comment 2

[:Gela]

Attachment: Bug 1969980 - part 2 - remove created and saved [sample search engine] toast

Comment 3

[:Gela]

Attachment: Bug 1969980 - part 3 - remove URL copied bookmark snackbar

Comment 4

[:Gela]

Attachment: Bug 1969980 - part 4 - remove collection renamed snackbar

Comment 5

[:Gela]

Attachment: Bug 1969980 - part 5 - remove Tabs saved snackbar

Comment 6

[:Gela]

Attachment: Bug 1969980 - part 6 - Remove multiple snackbars marked for deletion

Comment 7

[:Gela]

Attachment: Bug 1969980 - part 7 - Remove Site removed snackbar

Comment 8

[:Gela]

Attachment: Bug 1969980 - part 8 - Remove Deleted [search engine name] snackbar

Comment 9

[:Gela]

Attachment: Bug 1969980 - part 9 - Remove Deleted [Tab name] and History Deleted snackbars

Comment 10

[:Gela]

Attachment: Bug 1969980 - part 10 - Remove Collection deleted snackbar

Comment 11

[:Gela]

Attachment: Bug 1969980 - part 11 - Remove Deleted [bookmark] snackbar

Comment 12

[:Gela]

Attachment: Bug 1969980 - part 12 - Remove snackbars related to addons

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/af81ce7a5041
https://hg.mozilla.org/integration/autoland/rev/6093f3bdb939
part 1 - remove password saved and username updated snackbars r=android-reviewers,twhite,android-l10n-reviewers,delphine

Comment 14

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/6093f3bdb939

Comment 15

[Takanori MATSUURA]

Reopened for unpublished patches.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/30815a2dbdf6
https://hg.mozilla.org/integration/autoland/rev/ebdbd6e426db
part 3 - remove URL copied bookmark snackbar r=android-reviewers,android-l10n-reviewers,delphine,mavduevskiy

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c25a06ff1677
https://hg.mozilla.org/integration/autoland/rev/3d815cf63ca8
Revert "Bug 1969980 - part 3 - remove URL copied bookmark snackbar r=android-reviewers,android-l10n-reviewers,delphine,mavduevskiy" for causing lint failures @ SnackbarBindingTest.kt

Comment 18

[amarc]

Backed out for causing lint failure

• Backout link
• Push with failures
• Failure Log

Later edit: Fenix failure -> https://treeherder.mozilla.org/logviewer?job_id=517922419&repo=autoland

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f8ee1b5aad0f
https://hg.mozilla.org/integration/autoland/rev/b8a0a82c42cd
part 2 - remove created and saved [sample search engine] toast r=android-reviewers,android-l10n-reviewers,delphine,mavduevskiy,twhite

Comment 20

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b8a0a82c42cd

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/eadb9bea7b99
https://hg.mozilla.org/integration/autoland/rev/78f0c5ad0ee1
part 3 - remove URL copied bookmark snackbar r=android-reviewers,android-l10n-reviewers,delphine,mavduevskiy

Comment 22

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1969980 - part 3.5 - Update BookmarksMiddlewareTest for showUrlCopiedSnackbar removal.

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/47c306f73d16
https://hg.mozilla.org/integration/autoland/rev/579609a7d45c
part 3.5 - Update BookmarksMiddlewareTest for showUrlCopiedSnackbar removal.

Comment 24

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1969980 - part 3.75 - Remove snackbar dependency from failing test. r=gmalekpour

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a6e541cb18c2
https://hg.mozilla.org/integration/autoland/rev/3862f7d3e5c3
part 3.75 - Remove snackbar dependency from failing test. r=gmalekpour

Comment 26

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/78f0c5ad0ee1
https://hg.mozilla.org/mozilla-central/rev/579609a7d45c
https://hg.mozilla.org/mozilla-central/rev/3862f7d3e5c3

Comment 27

[:Gela]

Attachment: Bug 1969980 - part 5 - remove Tabs saved snackbar

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/623222deb28a
https://hg.mozilla.org/integration/autoland/rev/3f385d7d6b4b
part 5 - remove Tabs saved snackbar r=android-reviewers,android-l10n-reviewers,delphine,mavduevskiy,twhite

Comment 29

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/3f385d7d6b4b

Comment 30

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a82135d31d51
https://hg.mozilla.org/integration/autoland/rev/7f96422b6690
part 12 - Remove snackbars related to addons r=android-addons-reviewers,willdurand,android-l10n-reviewers,delphine,twhite

Comment 31

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c57901e287a5
https://hg.mozilla.org/integration/autoland/rev/72514476fe29
part 4 - remove collection renamed snackbar r=android-reviewers,android-l10n-reviewers,007,delphine

Comment 32

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/7f96422b6690
https://hg.mozilla.org/mozilla-central/rev/72514476fe29

Comment 33

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9fa0346818c8
https://hg.mozilla.org/integration/autoland/rev/490c1daa133c
part 8 - Remove Deleted [search engine name] snackbar r=android-reviewers,mavduevskiy,android-l10n-reviewers,delphine

Comment 34

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/490c1daa133c

Comment 35

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e23b2360f589
https://hg.mozilla.org/integration/autoland/rev/14c04b6e7b2b
part 7 - Remove Site removed snackbar r=android-reviewers,mavduevskiy

Comment 36

[:Gela]

Attachment: Bug 1969980 - part 7.1 - Fix test for remove Site removed snackbar

Comment 37

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/717532ff853e
https://hg.mozilla.org/integration/autoland/rev/746ae8c71a89
part 7.1 - Fix test for remove Site removed snackbar r=RyanVM

Comment 38

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/14c04b6e7b2b
https://hg.mozilla.org/mozilla-central/rev/746ae8c71a89

Comment 39

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8a8c09cc9034
https://hg.mozilla.org/integration/autoland/rev/5a96b3be5550
part 10 - Remove Collection deleted snackbar r=android-reviewers,android-l10n-reviewers,delphine,mavduevskiy

Comment 40

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5a96b3be5550

Comment 41

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b63dffe4a17c
https://hg.mozilla.org/integration/autoland/rev/90dbe012ec12
part 9 - Remove Deleted [Tab name] and History Deleted snackbars r=android-reviewers,android-l10n-reviewers,delphine,mavduevskiy

Comment 42

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/90dbe012ec12

Comment 43

[twhite]

Attachment: Bug 1969980 - Update the doc for removeCollection function since the undo functionality was removed in part 10 https://phabricator.services.mozilla.com/D255848

Comment 44

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a0208ff86617
https://hg.mozilla.org/integration/autoland/rev/f19471da1340
Update the doc for removeCollection function since the undo functionality was removed in part 10 https://phabricator.services.mozilla.com/D255848 r=android-reviewers,gmalekpour

Comment 45

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/f19471da1340

Comment 46

[:Gela]

Attachment: Bug 1969980 - part 13 - Remove Site removed toast for shortcuts

Comment 47

[:Gela]

Attachment: Bug 1969980 - part 14 - Remove toast for Cookies and site data removed

Comment 48

[:Gela]

Attachment: WIP: Bug 1969980 - part 15 - Remove Items deleted: # and Deleted % snackbars

Comment 49

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d0cec1a0df0f
https://hg.mozilla.org/integration/autoland/rev/6bbf68c49aa4
part 13 - Remove Site removed toast for shortcuts r=android-reviewers,joberhauser

Comment 50

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/6bbf68c49aa4

Comment 51

[:Gela]

Attachment: Bug 1969980 - [part 16] Remove wallpaper updated snackbar

Comment 52

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/072abd24ab9c
https://hg.mozilla.org/integration/autoland/rev/d35d2cab6427
[part 16] Remove wallpaper updated snackbar r=android-reviewers,mavduevskiy

Comment 53

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d35d2cab6427

Comment 54

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d70d792d9231
https://hg.mozilla.org/integration/autoland/rev/410d56ba5f5c
part 14 - Remove toast for Cookies and site data removed r=android-reviewers,twhite

Comment 55

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/410d56ba5f5c

Comment 56

[:Gela]

Closing this ticket as most of the snackbars are removed. There are 2 outstanding ones for which I'm going to open individual tickets that will do a better job of tracking them considering that the changes required are more involved than some basic removals.

Comment 57

[Mira Lobontiu (Android QA)]

Verified on the Firefox for Android Nightly 144.0a1 from 9/8 with a Samsung Galaxy s24 (Android 15) that the following snackbars were removed:

• Device name cannot be empty - removed and replaced with in-line form error,
• Password saved,
• Username updated,
• Created [name of the search engine],
• Saved [name of the search engine],
• URL copied - removed and replaced with in-line form,
• Invalid URL - removed and replaced with in-line form,
• Collection Saved! - removed and replaced with in-line form,
• Collection renamed,
• Tab saved! - replaced with in-line "Tab saved",
• Tab sent! - replaced with in-line form,
• Added to shortcuts! - removed and replaced with in-line form (in the spreadsheet it was supposed to be removed),
• Site removed,
• Browsing data deleted - removed and replaced with in-line form,
• Cookies and site data removed,
• Successfully uninstalled [name of the extension],
• Successfully enabled [name of the extension],
• Successfully disabled [name of the extension],
• Successfully removed [name of the extension],
• Deleted [name of the search engine] UNDO,
• Deleted [name of the file] UNDO - removed and replaced with in-line form (in the spreadsheet it was supposed to be removed),
• Items deleted: 2 UNDO - removed and replaced with in-line form (in the spreadsheet it was supposed to be removed),
• Wallpaper updated! VIEW,
• Deleted [name of the bookmark] UNDO,
• History deleted UNDO,
• Collection deleted UNDO,
• Site removed UNDO.

Comment 58

[Mira Lobontiu (Android QA)]

Attachment: examples.jpg

Comment 59

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.