Closed Bug 1970167 Opened 9 months ago Closed 9 months ago

Remove bottom divider under Private browsing

Categories

(Firefox for Android :: Privacy, task)

Product:
Firefox for Android
Component:
Privacy
Version:
Firefox 140
Platform:
All
Android
Type:
task

Tracking

()

Status:
VERIFIED FIXED
Milestone:
141 Branch
Tracking Flags:
Tracking Status
firefox140 --- verified
firefox141 --- verified

People

(Reporter: Gela, Assigned: Gela)

References

Details

(Whiteboard: [fxdroid][group2])

Attachments

(4 files)

Bug 1970167 - Remove bottom divider under Private browsing menu
48 bytes, text/x-phabricator-request
Details | Review
Bug 1970167 - Remove bottom divider under Private browsing menu
48 bytes, text/x-phabricator-request
phab-bot
: approval-mozilla-beta+
Details | Review
pic1.jpg
68.80 KB, image/jpeg
Details
pic2.jpg
66.68 KB, image/jpeg
Details
No description provided.
Summary: Remove bottom divider and update pref key name → Remove bottom divider under Private browsing
Attachment #9493120 - Flags: approval-mozilla-beta?

firefox-beta Uplift Approval Request

  • User impact if declined: Small mismatch with the Figma, might not be clear to users that the 2 menu options are grouped together
  • Code covered by automated testing: no
  • Fix verified in Nightly: yes
  • Needs manual QE test: no
  • Steps to reproduce for manual QE testing: Compare with Figma listed in 1969915
  • Risk associated with taking this patch: Low
  • Explanation of risk level: Adds a divider to make the groupings in the menu clearer but does not have any further technical implications
  • String changes made/needed: n/a
  • Is Android affected?: yes
Pushed by gmalekpour@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/ba4c26f4e9a2 https://hg.mozilla.org/integration/autoland/rev/20dd2414f58c Remove bottom divider under Private browsing menu r=android-reviewers,mavduevskiy

https://hg.mozilla.org/mozilla-central/rev/20dd2414f58c

Status: NEW → RESOLVED
Closed: 9 months ago
status-firefox141: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 141 Branch
Attachment #9493120 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

This issue was verified on Firefox for Android Nightly 141.0a1 (2025-06-09) and Firefox 140 beta 7 under Samsung S24 Ultra (Android 15) and Sony Xperia Z5 (Android 7.1.1) and here are the results:

  • there is a separator displayed above the "Use screen lock to hide tabs in private browsing" when no screen lock is set up (pic1)
  • there is no separator displayed when the screen lock is set up (pic 2)

Gela, could you please confirm that these results are as expected? Thanks!

Flags: needinfo?(gmalekpour)

(In reply to Vasilica Tamas QA [:vtamas] from comment #7)

This issue was verified on Firefox for Android Nightly 141.0a1 (2025-06-09) and Firefox 140 beta 7 under Samsung S24 Ultra (Android 15) and Sony Xperia Z5 (Android 7.1.1) and here are the results:

  • there is a separator displayed above the "Use screen lock to hide tabs in private browsing" when no screen lock is set up (pic1)
  • there is no separator displayed when the screen lock is set up (pic 2)

Gela, could you please confirm that these results are as expected? Thanks!

This behavior seems to be expected based on slack discussions and updated figma design:

  • The divider above the screen lock list item appears only when the ‘Set up screen lock’ list appears if they haven’t set up screen lock.
  • In all other cases, we do not show the divider line.

Closing this bug as Verified.

Status: RESOLVED → VERIFIED
Flags: needinfo?(gmalekpour)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: