1970225 - [GeckoView] Multi - Get and Set Gecko Preferences

Status: RESOLVED FIXED

(GeckoView :: General, task)

Description

[Olivia Hall [:olivia]]

This bug is to look into add a multi preference getter and setter for GeckoView to reduce messaging on bulk operations.

For example, getGeckoPreference(List<Strings>) and similar for setting.

Comment 1

[Olivia Hall [:olivia]]

This has changed some it needs to also have expected pref state on the setter.

Comment 2

[Olivia Hall [:olivia]]

Attachment: Bug 1970225 - GeckoView Option to Get Multiple Prefs

This patch expands the GeckoView preference API to add an option to
get multiple preferences.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a1cde27a58c1
https://hg.mozilla.org/integration/autoland/rev/53ff82beb3bc
GeckoView Option to Get Multiple Prefs r=geckoview-reviewers,geckoview-api-reviewers,nika,owlish

Comment 4

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/53ff82beb3bc

Comment 5

[Olivia Hall [:olivia]]

Attachment: Bug 1970225 - GeckoView Multi-Preference Setter with State Check

This patch adds a new GeckoView API that adds a method to only set a
Gecko preference if it currently matches the previous expected preference
value.

It additionally adds an object that contains setting information.

Comment 6

[Olivia Hall [:olivia]]

Attachment: Bug 1970225 - GeckoView Multi-Preference Setter

This bug adds:

• A way to set multiple Gecko preferences at once from GeckoView.
• Introduces SetGeckoPreference as an object to hold setting information.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/355a71b331ab
https://hg.mozilla.org/integration/autoland/rev/cf6f4bf50b97
GeckoView Multi-Preference Setter r=geckoview-reviewers,geckoview-api-reviewers,owlish,nika

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/cf6f4bf50b97