1970251 - Follow up on FIXME in BasePrincipal::CheckMayLoadHelper

Status: NEW

(Core :: Security: CAPS, task)

Description

[Daniel Holbert [:dholbert]]

I noticed this when reading some code:

https://searchfox.org/mozilla-central/rev/475c968d00995daab9fc257f683c7815c4345cb4/caps/BasePrincipal.cpp#625-628,678-684

nsresult BasePrincipal::CheckMayLoadHelper(nsIURI* aURI,
                                           bool aAllowIfInheritsPrincipal,
                                           bool aReport,
                                           uint64_t aInnerWindowID) {
...
  if (aReport) {
    // FIXME: Once bug 1900706 is complete, reporting can be updated to work
    // off-main-thread.
    nsScriptSecurityManager::ReportError("CheckSameOriginError", prinURI, aURI,
                                         mOriginAttributes.IsPrivateBrowsing(),
                                         aInnerWindowID);
  }

Bug 1900706 is in fact complete, so maybe we can take action on that FIXME now? (Not sure if it's high priority enough to do right now, but maybe it'd be worth dropping some more notes about what a fix might look like into this bug, and we can morph this bug into a more specific followup to track addressing this comment when cycles are available?)

(historical note: this FIXME was added in this commit for bug 1901387.)