Closed
Bug 1970304
Opened 1 year ago
Closed 9 months ago
CID 1648399 - Resource leak in shlibsign.c
Categories
(NSS :: Libraries, defect, P5)
NSS
Libraries
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Sylvestre, Assigned: rrelyea)
References
(Blocks 1 open bug)
Details
(Keywords: coverity)
Attachments
(1 file)
https://hg-edge.mozilla.org/projects/nss/file/tip/cmd/shlibsign/shlibsign.c#l1400
CID 1648399 Resource leak
7. leaked_storage: Variable keyItem going out of scope leaks the storage keyItem.data points to.
|
Reporter | |
Updated•1 year ago
|
Blocks: coverity-analysis
|
Assignee | |
Comment 2•11 months ago
|
||
keyItem.data isn't freed in any part of this branch, not just the error case. I suspect this isn't a regression from the earlier code, it just shows up as a new signature to coverity. It's a valid complaint, though I'll supply a patch to fix.
Assignee: nobody → rrelyea
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•10 months ago
|
||
- Fix data leak in shlibsign.c
- Also fix linkage for shlibsign.c shlibsign should not depend on any
shared library == freebl or above.
|
|
Assignee | |
Comment 4•10 months ago
|
||
I have a patch waiting for review, so I can clear the need info for myself.
Flags: needinfo?(rrelyea)
|
||
Updated•10 months ago
|
Severity: -- → S4
Priority: -- → P5
|
|
Assignee | |
Updated•9 months ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•