./mach try's output in the terminal is noisy
Categories
(Developer Infrastructure :: Try, defect)
Tracking
(Not tracked)
People
(Reporter: florian, Unassigned)
References
Details
Example:
$ ./mach try again
estimates: Runs 1 tasks (1 selected, 0 dependencies)
estimates: Total task duration 0:00:00
estimates: Should take about 0:00:00 (Finished around 2025-06-04 12:33)
Note: `--push-to-lando` is now the default behaviour of `mach try`.
Note: Use `--push-to-vcs` to push changes to try directly.
Auth0 token validated.
Using b75f7675fbad52777b8bf850e5cd172f495ffafe as the hg base commit.
Submitting 1 node and the try commit.
Patches gathered for submission.
Submitting patches to Lando.
Lando try submission success, took 26.2 seconds. Landing job id: 135160.
Lando Job Status API: https://api.lando.services.mozilla.com/landing_jobs/135160
Follow the progress of your build on Treeherder: https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=135160
The first 6 lines seem to appear all at once. A line that says how many tasks are selected could be useful, but the current estimates are so off that they are useless.
The 2 lines of notes about --push-to-lando made sense when that behavior was new, but I think we can now remove them.
The "Auth0 token validated." line seems like leftover debugging output. But it makes sense to write something when we expect an action from the user (like clicking something in the browser tab that has opened).
I'm not sure how useful the "Using b75f7675fbad52777b8bf850e5cd172f495ffafe as the hg base commit." line is. I never had a use case for it, but it may help some debugging? Maybe it would be behind the --verbose flag.
The 3 lines that say "Submitting 1 node and the try commit." then "Patches gathered for submission." and "Submitting patches to Lando." feel like they should be merged into a single line.
The last 3 lines could be merged and should show a single url.
For example:
Success! Submission to lando took 26s, follow progess of your builds at: <treeherder url>
|
||
Updated•1 year ago
|
|
Reporter | |
Comment 1•1 year ago
|
||
(In reply to Florian Quèze [:florian] from comment #0)
The first 6 lines seem to appear all at once. A line that says how many tasks are selected could be useful, but the current estimates are so off that they are useless.
I also noticed that making these estimates is expensive: today it delayed my try push by more than 4 seconds, as can be seen in this profile: https://share.firefox.dev/4eWi2hy
|
|
Reporter | |
Comment 2•1 year ago
|
||
(In reply to Florian Quèze [:florian] from comment #1)
(In reply to Florian Quèze [:florian] from comment #0)
The first 6 lines seem to appear all at once. A line that says how many tasks are selected could be useful, but the current estimates are so off that they are useless.
I also noticed that making these estimates is expensive: today it delayed my try push by more than 4 seconds, as can be seen in this profile: https://share.firefox.dev/4eWi2hy
And apparently there's no caching, running mach try again makes me wait about as long for estimates as the first try push: https://share.firefox.dev/4lV6rBO
Description
•