Closed Bug 1970351 Opened 1 year ago Closed 1 year ago

Copy as cURL (POSIX) adds ^ in front of query params separator (^&)

Categories

(DevTools :: Netmonitor, defect, P2)

Firefox 139
defect

Tracking

(firefox-esr115 wontfix, firefox-esr128 wontfix, firefox-esr140 wontfix, firefox139 wontfix, firefox140 wontfix, firefox141 wontfix, firefox142 fixed)

RESOLVED DUPLICATE of bug 1974973
Tracking Status
firefox-esr115 --- wontfix
firefox-esr128 --- wontfix
firefox-esr140 --- wontfix
firefox139 --- wontfix
firefox140 --- wontfix
firefox141 --- wontfix
firefox142 --- fixed

People

(Reporter: gregoire.piat, Assigned: bomsy)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 obsolete file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:140.0) Gecko/20100101 Firefox/140.0

Steps to reproduce:

Version: 140.0b4 on Windows

I went to a website using REST APIs with query params.
I opened the dev tools and went to the Network tab.
I selected a network call with an URL containing query params separated by & character.
I did a right click -> Copy as cURL (POSIX)

Can be reproduced on https://datausa.io/api/data?drilldowns=Nation&measures=Population

Actual results:

On my clipboard, I had the following value
curl 'https://datausa.io/api/data?drilldowns=Nation^&measures=Population'
--compressed
-H 'User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:140.0) Gecko/20100101 Firefox/140.0'
-H 'Accept: text/html,application/xhtml+xml,application/xml;q=0.9,/;q=0.8'
-H 'Accept-Language: en-US,en;q=0.8,fr;q=0.5,fr-FR;q=0.3'
-H 'Accept-Encoding: gzip, deflate, br, zstd'
-H 'DNT: 1'
-H 'Connection: keep-alive'
-H 'Upgrade-Insecure-Requests: 1'
-H 'Sec-Fetch-Dest: document'
-H 'Sec-Fetch-Mode: navigate'
-H 'Sec-Fetch-Site: cross-site'
-H 'Sec-GPC: 1'
-H 'Priority: u=0, i'
-H 'Pragma: no-cache'
-H 'Cache-Control: no-cache'
-H 'TE: trailers'

You can notice that the URL contains a ^&

Expected results:

I should not have a ^ in front of the & query param separator.
I should have following value in my clipboard:

curl 'https://datausa.io/api/data?drilldowns=Nation&measures=Population'
--compressed
-H 'User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:140.0) Gecko/20100101 Firefox/140.0'
-H 'Accept: text/html,application/xhtml+xml,application/xml;q=0.9,/;q=0.8'
-H 'Accept-Language: en-US,en;q=0.8,fr;q=0.5,fr-FR;q=0.3'
-H 'Accept-Encoding: gzip, deflate, br, zstd'
-H 'DNT: 1'
-H 'Connection: keep-alive'
-H 'Upgrade-Insecure-Requests: 1'
-H 'Sec-Fetch-Dest: document'
-H 'Sec-Fetch-Mode: navigate'
-H 'Sec-Fetch-Site: cross-site'
-H 'Sec-GPC: 1'
-H 'Priority: u=0, i'
-H 'Pragma: no-cache'
-H 'Cache-Control: no-cache'
-H 'TE: trailers'

Component: Untriaged → Netmonitor
Product: Firefox → DevTools
Keywords: regression
Regressed by: CVE-2025-5264
Severity: -- → S3
Priority: -- → P2
Assignee: nobody → hmanilla
Attachment #9494025 - Attachment description: WIP: Bug 1970351 - [devtools] Stop escaping special characters in the url → Bug 1970351 - [devtools] Stop escaping the query string special characters in the url r=#devtools
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

Set release status flags based on info from the regressing bug 1950001

Duplicate of this bug: 1971667
Version: Firefox 140 → Firefox 139

[Tracking Requested - why for this release]:

This will not make beta for Fx140, but we could take it as a ride-along later (RC/dot release)
Please add a release uplift request when this is ready.
It looks like it's needed on ESR also, so it will need uplift requests there too.

The bug is marked as tracked for firefox140 (beta). However, the bug still has low severity.

:Honza, could you please increase the severity for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Flags: needinfo?(odvarko)

This is tracked for release as requested last week.
Fx141 goes to beta on Monday. This will also need an beta uplift if it doesn't land before Merge Day.

Set release status flags based on info from the regressing bug 1950001

:bomsy, this is tracked for release as requested.
Fx140 is now live, but there is a planned dot release in a couple of weeks.
We can include this if it's safe to include as a ride along? Release uplift request needed by eod on 2026-06-04

Flags: needinfo?(hmanilla)
Flags: needinfo?(odvarko)
Whiteboard: [devtools-triage]

(In reply to Donal Meehan [:dmeehan] from comment #9)

:bomsy, this is tracked for release as requested.
Fx140 is now live, but there is a planned dot release in a couple of weeks.
We can include this if it's safe to include as a ride along? Release uplift request needed by eod on 2026-06-04

Sure, that sounds fine. Once reviewed. thanks Donal.

Flags: needinfo?(hmanilla)

Let's review the current patch and land this + uplift to beta potentially. Then file a followup to remove the cross platform escaping and clarify the situation with security team.

Whiteboard: [devtools-triage]
Comment 2 is private: false
Comment 8 is private: false
Depends on: 1974973

(In reply to Hubert Boma Manilla (:bomsy) from comment #10)

(In reply to Donal Meehan [:dmeehan] from comment #9)

:bomsy, this is tracked for release as requested.
Fx140 is now live, but there is a planned dot release in a couple of weeks.
We can include this if it's safe to include as a ride along? Release uplift request needed by eod on 2026-06-04

Sure, that sounds fine. Once reviewed. thanks Donal.

This is not on track to make the Fx140 planned dot release.
It would need to land in central, beta and get a release request uplift by EOD Friday 2025-07-04.

It's too late for Fx140
:bomesy, next week is the final week of beta for Fx141, so there is little time to land and uplift

Flags: needinfo?(hmanilla)
Attachment #9494025 - Attachment is obsolete: true

(In reply to Donal Meehan [:dmeehan] from comment #13)

It's too late for Fx140
:bomesy, next week is the final week of beta for Fx141, so there is little time to land and uplift
Hi Donal,
Thanks for the reminder. We decided to undo the work in bug 1950001 which led to this issue. The revert is being done in Bug 1974973.
We should be able to close this once that lands. Thanks

Flags: needinfo?(hmanilla)

Closing this as Bug 1974973 has landed

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Duplicate of bug: 1974973
Resolution: --- → DUPLICATE
Blocks: curl
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: