Closed
Bug 1970375
Opened 3 months ago
Closed 3 months ago
don't auto-retry notarization jobs
Categories
(Release Engineering :: Release Automation, task)
Release Engineering
Release Automation
Tracking
(firefox-esr115 fixed, firefox-esr128 fixed, firefox139 fixed, firefox140 fixed, firefox141 fixed)
People
(Reporter: jcristau, Assigned: jcristau)
Details
Attachments
(4 files, 1 obsolete file)
48 bytes,
text/x-phabricator-request
|
dmeehan
:
approval-mozilla-beta+
|
Details | Review |
48 bytes,
text/x-phabricator-request
|
phab-bot
:
approval-mozilla-release+
|
Details | Review |
48 bytes,
text/x-phabricator-request
|
phab-bot
:
approval-mozilla-esr128+
|
Details | Review |
48 bytes,
text/x-phabricator-request
|
phab-bot
:
approval-mozilla-esr115+
|
Details | Review |
When there's an issue with notarization workers, auto-retry can end up turning 1 failure into 6 failures, 100 failures into 600 failures, all the while using up our rate limit, making recovery harder.
Assignee | ||
Comment 1•3 months ago
|
||
Updated•3 months ago
|
Assignee: nobody → jcristau
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•3 months ago
|
||
Original Revision: https://phabricator.services.mozilla.com/D252505
Updated•3 months ago
|
Attachment #9493071 -
Flags: approval-mozilla-beta?
Comment 3•3 months ago
|
||
firefox-beta Uplift Approval Request
- User impact if declined: delayed releases
- Code covered by automated testing: no
- Fix verified in Nightly: no
- Needs manual QE test: no
- Steps to reproduce for manual QE testing: n/a
- Risk associated with taking this patch: low
- Explanation of risk level: just changing task config to prevent retries making things worse in case of issues with notarization workers
- String changes made/needed: n/a
- Is Android affected?: no
Assignee | ||
Comment 4•3 months ago
|
||
Original Revision: https://phabricator.services.mozilla.com/D252505
Updated•3 months ago
|
Attachment #9493072 -
Flags: approval-mozilla-release?
Assignee | ||
Comment 5•3 months ago
|
||
Original Revision: https://phabricator.services.mozilla.com/D252505
Updated•3 months ago
|
Attachment #9493073 -
Flags: approval-mozilla-esr128?
Assignee | ||
Comment 6•3 months ago
|
||
Original Revision: https://phabricator.services.mozilla.com/D252505
Updated•3 months ago
|
Attachment #9493074 -
Flags: approval-mozilla-esr115?
Pushed by jcristau@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/36d99a2df891
https://hg.mozilla.org/integration/autoland/rev/247f82ec8fef
don't retry notarization tasks. r=releng-reviewers,taskgraph-reviewers,Eijebong DONTBUILD
Comment 8•3 months ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
status-firefox141:
--- → fixed
Resolution: --- → FIXED
Updated•3 months ago
|
Attachment #9493071 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•3 months ago
|
status-firefox140:
--- → fixed
Updated•3 months ago
|
Attachment #9493071 -
Flags: approval-mozilla-beta+ → approval-mozilla-beta?
Updated•3 months ago
|
Attachment #9493071 -
Attachment is obsolete: true
Attachment #9493071 -
Flags: approval-mozilla-beta? → approval-mozilla-beta-
Updated•3 months ago
|
Attachment #9492703 -
Flags: approval-mozilla-beta+
Updated•3 months ago
|
Attachment #9493072 -
Attachment description: Bug 1970375 - don't retry notarization tasks. r?#releng → Bug 1970375 - don't retry notarization tasks.
Attachment #9493072 -
Flags: approval-mozilla-release? → approval-mozilla-release+
Updated•3 months ago
|
status-firefox139:
--- → fixed
Comment 10•3 months ago
|
||
uplift |
Updated•3 months ago
|
Attachment #9493073 -
Attachment description: Bug 1970375 - don't retry notarization tasks. r?#releng → Bug 1970375 - don't retry notarization tasks.
Updated•3 months ago
|
Attachment #9493074 -
Attachment description: Bug 1970375 - don't retry notarization tasks. r?#releng → Bug 1970375 - don't retry notarization tasks.
Updated•3 months ago
|
Attachment #9493074 -
Flags: approval-mozilla-esr115? → approval-mozilla-esr115+
Updated•3 months ago
|
status-firefox-esr115:
--- → fixed
Comment 11•3 months ago
|
||
uplift |
Updated•3 months ago
|
Attachment #9493073 -
Flags: approval-mozilla-esr128? → approval-mozilla-esr128+
Updated•3 months ago
|
status-firefox-esr128:
--- → fixed
Comment 12•3 months ago
|
||
uplift |
You need to log in
before you can comment on or make changes to this bug.
Description
•