1970598 - Frequent error "WeakMap key undefined must be an object" in WindowManager

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P3)

Description

[Julian Descottes [:jdescottes]]

When navigating to eg cnn.com, STDOUT is full of errors such as console.error: (new TypeError("WeakMap key undefined must be an object", "chrome://remote/content/shared/WindowManager.sys.mjs", 189))

TypeError: WeakMap key undefined must be an object
    getIdForWindow chrome://remote/content/shared/WindowManager.sys.mjs:189
    #onContextAttached chrome://remote/content/shared/WindowManager.sys.mjs:521
    emit resource://gre/modules/EventEmitter.sys.mjs:156
    observe chrome://remote/content/shared/listeners/BrowsingContextListener.sys.mjs:74
EventEmitter.sys.mjs:158:19

We should nullcheck window at https://searchfox.org/mozilla-central/rev/bd57b566959758d0455c6e37afca00648c8e4ff0/remote/shared/WindowManager.sys.mjs#517-522

#onContextAttached = (_, data = {}) => {
  const { browsingContext } = data;

  const window = this.#getBrowsingContextWindow(browsingContext);
  this.#clientWindowIds.set(browsingContext, this.getIdForWindow(window));
};

This probably happens for shortlived iframes?

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:whimboo, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Julian Descottes [:jdescottes]]

This really results in a lot of log pollution when trying to debug real websites, so I'm going to address this.

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1970598 - [remote] Avoid log pollution from short lived iframes in WindowManager

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cb99fc828cd9
https://hg.mozilla.org/integration/autoland/rev/10c49ed3bbbb
[remote] Avoid log pollution from short lived iframes in WindowManager r=webdriver-reviewers,whimboo

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/10c49ed3bbbb