1970679 - After comment edit, relevant attachment comment disappears until `window.reload`.

Status: NEW

(bugzilla.mozilla.org :: User Interface, defect, P3)

Description

[Mr. Beedell, Roke Julian Lockhart (RJLB)]

Attachment: A Screencast That Demonstrates How To Reproduce This

An example is page.cgi?id=comment-revisions.html&bug_id=1963035&comment_id=17525389.

Steps to reproduce

1. Create a bug.

2. Upload an attachment.

3. Comment on that attachment, whilst modifying its name, so that this is attached to a comment in the bug timeline.

4. Modify the content of that comment.

   Actual results

   The attachment name modification disappears from the comment.

   Expected results

   It shouldn't disappear.

5. Fire window.reload().

   The attachment name modification re-appears in the comment.

Comment 1

[David Lawrence [:dkl]]

This is because the "Comment on attachment XXX [details]" portion of the comment is not from the comment text itself and is automatically generated and pre-pended to the comment when rendering. This happens in some other special cases as well. To fix this we would need to separate out the auto-generated text from the actual comment text and then when editing a comment, only the comment text is re-rendered. This is something we can look at when we have more time and resources as reloading the page is a workaround for now.