197084 - [AxPlugin] Install activex.js default prefs

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Adam Lock]

COM connect / ActiveX work needs a default set of prefs defining the blacklist /
whitelist mode and hosting flags. These should go into an activex.js file which
is installed into mozilla/defaults/pref

By default it should probably operate in blacklist mode with a resonably
security set of flags, and otherwise be blank anticipating that embedders will
probably wish to write their own version anyway.

Inline documentation would also help embedders customize this file.

Comment 1

[Adam Lock]

Attachment: Work in progress

This patch adds activex.js and is complete except for the default caps prefs.

Comment 2

[Adam Lock]

Attachment: Patch

Patch adds the pref file activex.js to the files exported by the plugin. The
pref file puts caps into blacklist mode and contains comments demonstrating how
embedders might change these settings. The expectation is that embedders will
override this file with their own if they are interested in this functionality,
much as they already do with other settings such as user agent etc.

Comment 3

[Adam Lock]

Attachment: Patch 2

Second patch adds more comments.

Comment 4

[Adam Lock]

David & Arun. Are you satisfied with the default behaviour that this patch
implements in activex.js?

Comment 5

[Adam Lock]

Comment on attachment 118040 [details] [diff] [review]
Patch 2

Assuming that the silence means people are happy with this being the default
behaviour at least for now, can I have an r/sr on this please?

Comment 6

[Alec Flett]

Comment on attachment 118040 [details] [diff] [review]
Patch 2

sr=alecf

Comment 7

[Alec Flett]

Comment on attachment 118040 [details] [diff] [review]
Patch 2

though I tell you what - normally I'm all about the comments, but in prefs
files, we really prefer to keep comments to a minimum because reading of prefs
files is really bloaty, plus these files are stored uncompressed in a given
installation. Can you take out these comments and put them in documentation on
mozilla.org somewhere? 

You can still check in of course before the docs go up on the website..

(let me know if I can help you get them on mozilla.org)

Comment 8

[Adam Lock]

I'll leave the comments in for the time being until our activex story and we
have a page of documentation on mozilla.org we can put a link to instead.

Comment 9

[David Bradley]

Comment on attachment 118040 [details] [diff] [review]
Patch 2

r=dbradley

Comment 10

[Adam Lock]

Comment on attachment 118040 [details] [diff] [review]
Patch 2

Requesting 1.4a approval. Specific to activex work, patch adds the default
settings file.

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 118040 [details] [diff] [review]
Patch 2

a=asa (on behalf of drivers) for checkin to 1.4a

Comment 12

[Adam Lock]

Fix is checked in