1970905 - Execute Windows Backup fix during PostUpdate

Status: VERIFIED FIXED

(Firefox :: Shell Integration, enhancement, P3)

Description

[Max Christian Pohle [:/dev/max]]

Windows Backup can be used to migrate from Windows 10 to Windows 11. It restores placeholder items in the Start menu for applications installed under Windows 10. Windows Backup uses the uninstall keys in the registry to determine which applications are installed. However, our uninstall key contains a version number, which has caused problems like Bug 1505436 in the past.

This ticket attempts to solve this problem for most users. Those who installed Firefox in the default location, C:\Program Files\Mozilla Firefox, will receive a different uninstall key that does not contain a version number. This ensures that Windows Backup does not have to search for version numbers that it may not recognize and helps users restore the most recent version of Firefox.

Users who already have Firefox installed will be migrated to the new Uninstall key scheme if applicable.

After a fresh installation, users will see a placeholder icon with the Firefox logo in their Windows 11 Start menu. Clicking it opens a Windows Store dialog box with buttons to the vendor's website.

Comment 1

[Max Christian Pohle [:/dev/max]]

Attachment: Bug 1970905 - Fix Windows Backup r?nrishel,cdupuis r=bytesized

Comment 2

[Max Christian Pohle [:/dev/max]]

The latest version includes a fix for Bug 1978591.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1db206ef6df4
https://hg.mozilla.org/integration/autoland/rev/ae8ab407665c
Fix Windows Backup r=nrishel,cdupuis,bytesized,browser-installer-reviewers

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/ae8ab407665c

Comment 6

[Bogdan Maris, Desktop Test Engineering [OOO until Dec 16th]]

I tested on Windows 10 64bit and 32bit and I can confirm that the name of the Nightly folder inside all the bellow paths is now changed from Nightly 142.0a1 (x64 en-US) into Nightly at install or updating from an old version to the latest one.

HKCU\Software\Microsoft\Windows\CurrentVersion\Uninstall
HKLM\Software\Microsoft\Windows\CurrentVersion\Uninstall
HKLM\SOFTWARE\WOW6432Node\Microsoft\Windows\CurrentVersion\Uninstall

This does not work right now on Windows 11, but it is planned to work in the future (will retest once that change happens).

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d5c80ed44520
https://hg.mozilla.org/releases/mozilla-release/rev/62b30a28e7a4
Revert "Bug 1970905 - Fix Windows Backup r=nrishel,cdupuis,bytesized,browser-installer-reviewers" for causing bug 1987156.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Sorry for the mistake in the backout commit message. For posterity, bug 1983996 was the reason for the backout from 143.