1971000 - `SuppressedError` constructor should not accept `cause` argument

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, defect)

Description

[zloirock]

Steps to reproduce:

new SuppressedError(1, 2, 3, { cause: 4 }).cause

Actual results:

4

Expected results:

undefined

Comment 1

[Tooru Fujisawa [:arai]]

Thank you for reporting!

Indeed, the SuppressedError constructor doesn't receive the options parameter.

https://arai-a.github.io/ecma262-compare/?pr=3000&id=sec-suppressederror

SuppressedError ( error, suppressed, message )

According to the following issue, not having the cause support is intentional.

https://github.com/tc39/proposal-explicit-resource-management/issues/147

Thus, we should skip the options handling for SuppressedError below

https://searchfox.org/mozilla-central/rev/1c29c547ab9f7d29a02c2b6e7f4f4a9facfe94fd/js/src/vm/ErrorObject.cpp#268-286

bool hasOptions = args.get(messageArg + 1).isObject();

Rooted<mozilla::Maybe<Value>> cause(cx, mozilla::Nothing());
if (hasOptions) {
  RootedObject options(cx, &args[messageArg + 1].toObject());

  bool hasCause = false;
  if (!HasProperty(cx, options, cx->names().cause, &hasCause)) {
    return nullptr;
  }

  if (hasCause) {
    RootedValue causeValue(cx);
    if (!GetProperty(cx, options, options, cx->names().cause, &causeValue)) {
      return nullptr;
    }
    cause = mozilla::Some(causeValue.get());
  }
}

Comment 2

[Debadree Chatterjee]

Attachment: Bug 1971000: Skip cause handling in SuppressedError. r?arai!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/686f1afadc73
https://hg.mozilla.org/integration/autoland/rev/5f1a873ef322
Skip cause handling in SuppressedError. r=arai

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5f1a873ef322