1971038 - Null check this.browser in context menu

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Ian Neal]

Potentially this.browser could be null in a context menu, so we should check it before trying to look at properties / attributes.

Comment 1

[Ian Neal]

Attachment: 1971038-context-browser-null-25322.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: context menu is not properly initialised
Testing completed (on m-c, etc.): 2.53.22pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9493475 [details] [diff] [review]
1971038-context-browser-null-25322.patch

LGTM r/a+

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1c858aa5f95e
Null check this.browser in context menu. r=frg DONTBUILD

Comment 4

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/91d3ef0decf68e38f2e07f34b4e6a9402ffcde33
Null check this.browser in context menu. r=frg a=frg