1971094 - Switching sources with the file search panel open breaks the search

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Hubert Boma Manilla (:bomsy)]

STR

1. Go to https://todomvc.com/ and open the devtools debugger
2. Select https://todomvc.com/site-assets/main.js
3. Do Ctrl/Cmd + F to open file search
4. Search for this (there should be around 17 entires). Moving through the search should work nicely
5. Select https://todomvc.com/bower_components/jquery/dist/jquery.js (Make sure the file search is still open)

What happened?

The search results does not update after the source is switched. And cycling through the search results is broken.

What should have happened?

A search results should update to match the current source selected.

Comment 1

[Hubert Boma Manilla (:bomsy)]

This probably regressed by Bug 1962417

Comment 2

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1971094 - [devtools] Update search results when the selected source changes r=#devtools

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1962417

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c853ad46f5b4
https://hg.mozilla.org/integration/autoland/rev/a11d351b9042
[devtools] Update search results when the selected source changes r=devtools-reviewers,nchevobbe

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/65ac775edabb
https://hg.mozilla.org/integration/autoland/rev/ea530ec099aa
Revert "Bug 1971094 - [devtools] Update search results when the selected source changes r=devtools-reviewers,nchevobbe" for causing failures at browser_dbg-search-file-retains-query.js.

Comment 6

[Atila Butkovits]

Backed out for causing failures at browser_dbg-search-file-retains-query.js..

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/ea530ec099aac8b9172137208a59e59e3bda68c6

Push where failures started: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=dQZtML4GR5usv3izkZ9lZg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=linux%2C18.04%2Cdebug%2Cmochitests%2Ctest-linux1804-64-qr%2Fdebug-mochitest-devtools-chrome%2Cdt10&revision=67baceb379aeddc2c4490ca806b6fe41921b5b3e

Failure log: https://treeherder.mozilla.org/logviewer?job_id=512708967&repo=autoland&lineNumber=8589

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/05081927e85b
https://hg.mozilla.org/integration/autoland/rev/8fb6b0c2f4d1
[devtools] Update search results when the selected source changes r=devtools-reviewers,nchevobbe

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/8fb6b0c2f4d1

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:bomsy, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox140 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1971094 - [devtools] Update search results when the selected source changes r=#devtools

Original Revision: https://phabricator.services.mozilla.com/D253015

Comment 11

[Donal Meehan [:dmeehan]]

Comment on attachment 9495427 [details]
Bug 1971094 - [devtools] Update search results when the selected source changes r=#devtools

:bomsy, beta is closed since we are in RC week for Fx140. This will ride the train to beta with Fx141.
I changed the target repo of your uplift revision to release.

We could take it in a ride along, but that depends on the uplift request. Please add the request form to in Phabricator.

Comment 12

[Hubert Boma Manilla (:bomsy)]

:bomsy, beta is closed since we are in RC week for Fx140. This will ride the train to beta with Fx141.
I changed the target repo of your uplift revision to release.

Sounds good! Thanks!

We could take it in a ride along, but that depends on the uplift request. Please add the request form to in Phabricator.

Not too clear what i need to do here, can you help clarify?

Comment 13

[Donal Meehan [:dmeehan]]

Uplift requests need some details to give context around risk, etc.
You can add it to the phabricator revision, see the following for some instructions:
https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift#Submit_the_Uplift_Request_Form

Comment 14

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined: Devtools debugger user will see wrong search results while switching source during a file search
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: -
• Risk associated with taking this patch: Low risk
• Explanation of risk level: Just javascript code change to do a search when the source changes
• String changes made/needed: -
• Is Android affected?: no

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1962417

Comment 16

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/c77d682c9413
https://hg.mozilla.org/releases/mozilla-release/rev/0e912bf7ea0c

Comment 17

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr140/rev/1223cdb5424f