layout of the button bar in search engines settings does not work well with longer translations
Categories
(Firefox :: Search, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr115 | --- | disabled |
| firefox-esr128 | --- | disabled |
| firefox139 | --- | disabled |
| firefox140 | --- | fix-optional |
| firefox141 | --- | fix-optional |
People
(Reporter: soeren.hentzschel, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
screenshot
Many languages (including German) tend to have longer words than English. In this case, the layout with the button bar in the search engine settings does not work very well. It's not a bug because the buttons become multiline when needed and that works. However, since buttons in the Firefox settings do not normally have such a height, this looks inappropriate. Perhaps it shouldn't be tried to get all four buttons in one row. Or you could increase the maximum width of the settings, which is very narrow anyway and also causes display problems in other places with content that is too long (for example bug 1971102).
|
||
Comment 1•4 months ago
|
||
This may still belong in the Settings UI component. We are in the process of replacing this UI, and the new designs only have a single button which should allow for longer text without the awkwardness of increasing the heights of adjacent buttons. We're fine with leaving this open until that work is complete, but I don't think we should address this issue directly in the interim.
|
||
Comment 2•4 months ago
|
||
(In reply to Hanna Jones [:hjones] from comment #1)
This may still belong in the Settings UI component. We are in the process of replacing this UI, and the new designs only have a single button which should allow for longer text without the awkwardness of increasing the heights of adjacent buttons. We're fine with leaving this open until that work is complete, but I don't think we should address this issue directly in the interim.
Nice, this is the first I've seen of the new UI (I don't think the search team has seen it yet).
Interestingly, the newly added "Add" button to manually add a search engine is not on the redesigned example. Maybe that's been missed because it is newly added? I'm therefore a little curious as to if the same problem here might occur if the "Add" button is added to the new UI.
|
|
||
Comment 3•4 months ago
|
||
Ah good call! I think that's probably just missing from the designs right now if it's new - I've pinged the designers over in Figma. I've also added a comment over in bug 1972071 (the bug for actually doing the conversion work) about the discrepancy + the fact that we will want to preserve the "Add" action.
Description
•