Closed
Bug 1971269
Opened 5 months ago
Closed 4 months ago
Handle *.hpp files in check_spidermonkey_style.py
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
142 Branch
| Tracking | Status | |
|---|---|---|
| firefox142 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
Bug 1971269 - Part 2: Remove support for legacy 'inlines.h' header files. r=#spidermonkey-reviewers!
48 bytes,
text/x-phabricator-request
|
Details | Review |
Bindings for ICU4x 2.0 use "*.hpp" files, which aren't currently recognised as header files in "check_spidermonkey_style.py". This requires to include "hpp" files after "*-inl.h" files, otherwise "check_spidermonkey_style.py" will complain.
Updated•5 months ago
|
| Assignee | ||
Comment 1•4 months ago
|
||
| Assignee | ||
Comment 2•4 months ago
|
||
Pushed by andre.bargull@gmail.com:
https://github.com/mozilla-firefox/firefox/commit/e7d1d792ac8c
https://hg.mozilla.org/integration/autoland/rev/f1e599413745
Part 1: Handle *.hpp files in check_spidermonkey_style. r=spidermonkey-reviewers,jandem
https://github.com/mozilla-firefox/firefox/commit/2a9eadf8a889
https://hg.mozilla.org/integration/autoland/rev/81ba63f115ec
Part 2: Remove support for legacy 'inlines.h' header files. r=spidermonkey-reviewers,jandem
https://github.com/mozilla-firefox/firefox/commit/98c51de23599
https://hg.mozilla.org/integration/autoland/rev/7ecf64081fcf
apply code formatting via Lando
Comment 4•4 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f1e599413745
https://hg.mozilla.org/mozilla-central/rev/81ba63f115ec
https://hg.mozilla.org/mozilla-central/rev/7ecf64081fcf
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
status-firefox142:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 142 Branch
Updated•4 months ago
|
QA Whiteboard: [qa-triage-done-c143/b142]
You need to log in
before you can comment on or make changes to this bug.
Description
•