Closed
Bug 197127
Opened 21 years ago
Closed 21 years ago
Mark clicked js urls as hidden in global history
Categories
(Core Graveyard :: History: Global, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.4alpha
People
(Reporter: nisheeth_mozilla, Assigned: nisheeth_mozilla)
References
()
Details
Attachments
(2 files)
2.61 KB,
patch
|
alecf
:
review+
hjtoi-bugzilla
:
superreview+
|
Details | Diff | Splinter Review |
786 bytes,
patch
|
alecf
:
review+
hjtoi-bugzilla
:
superreview+
asa
:
approval1.4a+
|
Details | Diff | Splinter Review |
For background, see bug 161531. The consensus opinion from that bug is to store clicked js urls in the global history but mark them as hidden so that they don't show up in the autocomplete ui. typed js urls should be stored in global history and also show up in the autocomplete ui.
Assignee | ||
Updated•21 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Updated•21 years ago
|
Target Milestone: --- → mozilla1.4alpha
Comment 1•21 years ago
|
||
oh lets leave data urls out of global history entirely.. they can be huge!
I think that would be fine too, data: is used so rarly that I doubt that any sites would break if they weren't in global history.
Assignee | ||
Comment 3•21 years ago
|
||
Man, I seem to be getting nothing right these days! :-) Changing summary...
Summary: Mark clicked js and data urls as hidden in global history → Mark clicked js urls as hidden in global history
Assignee | ||
Comment 4•21 years ago
|
||
We now hide JS urls in nsDocShell::AddPageToGlobalHistory(). Elsewhere in nsGlobalHistory::AddExistingPageToDatabase() there is existing code that unhides urls if they are typed. So, the end result is that clicked JS urls stay hidden and typed js urls get unhidden.
Assignee | ||
Comment 5•21 years ago
|
||
Comment on attachment 118356 [details] [diff] [review] First attempt at fix. Please see comment #4 that describes this fix. Alec, please r and Heikki, please sr. Thanks!
Attachment #118356 -
Flags: superreview?(heikki)
Attachment #118356 -
Flags: review?(alecf)
Comment 6•21 years ago
|
||
Comment on attachment 118356 [details] [diff] [review] First attempt at fix. ugh. I'm not tremendously happy with this fix, but I can't really think of a cleaner way right now... r=alecf
Attachment #118356 -
Flags: review?(alecf) → review+
Assignee | ||
Comment 7•21 years ago
|
||
i know, i'm not very happy with it either. i'm open to suggestions on improving it...
Updated•21 years ago
|
Attachment #118356 -
Flags: superreview?(heikki) → superreview+
Assignee | ||
Comment 8•21 years ago
|
||
Fix checked into trunk.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 9•21 years ago
|
||
i also want to check in a one line fix in sessionhistoryui.js that prevents typed js urls from entering global history. About to attach a patch and ask for review.
Assignee | ||
Comment 10•21 years ago
|
||
Assignee | ||
Comment 11•21 years ago
|
||
Comment on attachment 118506 [details] [diff] [review] Additional fix to prevent typed data urls from entering history A one liner fix that prevents typed data urls from entering global history. alec, please r=. heikki, please sr=. Thanks!
Attachment #118506 -
Flags: superreview?(heikki)
Attachment #118506 -
Flags: review?(alecf)
Comment 12•21 years ago
|
||
Comment on attachment 118506 [details] [diff] [review] Additional fix to prevent typed data urls from entering history sr=alecf
Attachment #118506 -
Flags: review?(alecf) → review+
Assignee | ||
Comment 13•21 years ago
|
||
Comment on attachment 118506 [details] [diff] [review] Additional fix to prevent typed data urls from entering history Please grant me approval to check in a 1 line security fix that prevents typed data urls from entering global history. The fix has been r/sr'd by alecf and I've tested the codepath with data and other urls. This is a very low risk patch. Thanks!
Attachment #118506 -
Flags: approval1.4a?
Updated•21 years ago
|
Attachment #118506 -
Flags: superreview?(heikki) → superreview+
Comment 14•21 years ago
|
||
Comment on attachment 118506 [details] [diff] [review] Additional fix to prevent typed data urls from entering history a=asa (on behalf of drivers) for checkin to 1.4a
Attachment #118506 -
Flags: approval1.4a? → approval1.4a+
Assignee | ||
Comment 15•21 years ago
|
||
patch 118506 checked into trunk...
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•