Closed Bug 197127 Opened 21 years ago Closed 21 years ago

Mark clicked js urls as hidden in global history

Categories

(Core Graveyard :: History: Global, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.4alpha

People

(Reporter: nisheeth_mozilla, Assigned: nisheeth_mozilla)

References

()

Details

Attachments

(2 files)

For background, see bug 161531.  The consensus opinion from that bug is to store
clicked js urls in the global history but mark them as hidden so that they don't
show up in the autocomplete ui.  typed js urls should be stored in global
history and also show up in the autocomplete ui.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.4alpha
oh lets leave data urls out of global history entirely.. they can be huge!
I think that would be fine too, data: is used so rarly that I doubt that any
sites would break if they weren't in global history.
Man, I seem to be getting nothing right these days!  :-)  Changing summary...
Summary: Mark clicked js and data urls as hidden in global history → Mark clicked js urls as hidden in global history
We now hide JS urls in nsDocShell::AddPageToGlobalHistory().  Elsewhere in
nsGlobalHistory::AddExistingPageToDatabase() there is existing code that
unhides urls if they are typed.  So, the end result is that clicked JS urls
stay hidden and typed js urls get unhidden.
Comment on attachment 118356 [details] [diff] [review]
First attempt at fix.

Please see comment #4 that describes this fix.	Alec, please r and Heikki,
please sr.

Thanks!
Attachment #118356 - Flags: superreview?(heikki)
Attachment #118356 - Flags: review?(alecf)
Comment on attachment 118356 [details] [diff] [review]
First attempt at fix.

ugh. I'm not tremendously happy with this fix, but I can't really think of a
cleaner way right now...

r=alecf
Attachment #118356 - Flags: review?(alecf) → review+
i know, i'm not very happy with it either.  i'm open to suggestions on improving
it...
Attachment #118356 - Flags: superreview?(heikki) → superreview+
Fix checked into trunk.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
i also want to check in a one line fix in sessionhistoryui.js that prevents
typed js urls from entering global history.  About to attach a patch and ask for
review.
Comment on attachment 118506 [details] [diff] [review]
Additional fix to prevent typed data urls from entering history

A one liner fix that prevents typed data urls from entering global history.

alec, please r=.  heikki, please sr=.

Thanks!
Attachment #118506 - Flags: superreview?(heikki)
Attachment #118506 - Flags: review?(alecf)
Comment on attachment 118506 [details] [diff] [review]
Additional fix to prevent typed data urls from entering history

sr=alecf
Attachment #118506 - Flags: review?(alecf) → review+
Comment on attachment 118506 [details] [diff] [review]
Additional fix to prevent typed data urls from entering history

Please grant me approval to check in a 1 line security fix that prevents typed
data urls from entering global history.  The fix has been r/sr'd by alecf and
I've tested the codepath with data and other urls.   This is a very low risk
patch.

Thanks!
Attachment #118506 - Flags: approval1.4a?
Attachment #118506 - Flags: superreview?(heikki) → superreview+
Comment on attachment 118506 [details] [diff] [review]
Additional fix to prevent typed data urls from entering history

a=asa (on behalf of drivers) for checkin to 1.4a
Attachment #118506 - Flags: approval1.4a? → approval1.4a+
patch 118506 checked into trunk...
QA Contact: kasumi → cpetersen0953
Blocks: 206750
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: