1971272 - Rename nsISHEntry.persist to transient and use it consistently

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P1)

Description

[Vincent Hilla [:vhilla]]

In bug 1945808, we want to ensure the initial about:blank entry is replaced by consecutive loads. A promising approach is to mark the session history entry as non-persistent.

I got a bit confused with this persist flag and it currently doesn't apply to child SH entries. Therefore, this bug performs a slight refactoring, expands the scope of the persist flag and documents it further.

Comment 1

[Vincent Hilla [:vhilla]]

Attachment: Bug 1971272 - Rename nsISHEntry.persist to transient and use it consistently. r=#dom-core,smaug,farre

A transient entry will be replaced if a new entry is added on top.

This patch achieves multiple goals

• nsISHEntry.persist is renamed to transient and defined more precisely.
• aPersist is removed as argument to several methods.
  • Instead, we call SetTransient() directly on the entry.
  • These methods mostly forwarded aPersist to nsSHistory::AddEntry, if they
    called it. But that meant that passing false for aPersist didn't always
    result in transient entries.
• We create the infrastructure for transient child entries to be replaced too.
  • Previously, the persistence flag was ignored on child entries
  • At the state of this patch, child entries shouldn't become transient. But
    they will once we always replace the initial about:blank entry.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/93b7c007a9b6
https://hg.mozilla.org/integration/autoland/rev/6ff447fe04d2
Rename nsISHEntry.persist to transient and use it consistently. r=smaug,farre,dom-core,sessionstore-reviewers,core-sessionstore-reviewers

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/6ff447fe04d2