1971371 - Unexpected authentication prompt after launching via pbm shortcut with no active private tabs

Status: VERIFIED FIXED

(Firefox for Android :: Privacy, defect)

Description

[:Gela]

Attachment: PBMShorcutBugScreen_recording_20250610_103952.mp4

Description:

Users are prompted to authenticate after entering a URL in the address bar when launching Firefox via the Private Browsing Mode (PBM) shortcut, even though no private tabs are active. This behavior is unexpected and disrupts the user flow.

Steps to Reproduce

1. Enable “Lock private tabs” in Firefox settings.
2. Create a Home screen shortcut for Private Browsing Mode.
3. Use this shortcut to launch Firefox.
4. Enter a URL in the address bar and tap Go.

Expected Behavior

Since there are no active private tabs, authentication should not be required

Actual Behavior

As soon as the user taps Go, they are prompted to authenticate, despite having no existing private tabs open.

Comment 1

[Mike a [:mavduevskiy]]

Attachment: Bug 1971371 - Part 1: Don't lock PBM when the app has focus

Comment 2

[Mike a [:mavduevskiy]]

Attachment: Bug 1971371 - Part 2: refactor to remove duplicated code

Comment 3

[Mike a [:mavduevskiy]]

Attachment: Bug 1971371 - Part 1: Don't lock PBM when the app has focus

Original Revision: https://phabricator.services.mozilla.com/D253258

Comment 4

[Mike a [:mavduevskiy]]

Attachment: Bug 1971371 - Part 2: refactor to remove duplicated code

Original Revision: https://phabricator.services.mozilla.com/D253451

Comment 5

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: notification permission request might trigger private mode lock
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: steps are in the ticket, they are tricky
• Risk associated with taking this patch: little
• Explanation of risk level: it will be a gradual rollout through Nimbus, the feature won't be available in release by default
• String changes made/needed: no
• Is Android affected?: yes

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4eacae557406
https://hg.mozilla.org/integration/autoland/rev/d3f98978bcf5
Part 1: Don't lock PBM when the app has focus r=android-reviewers,gmalekpour
https://github.com/mozilla-firefox/firefox/commit/27d3153837ef
https://hg.mozilla.org/integration/autoland/rev/834be332ed7f
Part 2: refactor to remove duplicated code r=android-reviewers,gmalekpour

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/d3f98978bcf5
https://hg.mozilla.org/mozilla-central/rev/834be332ed7f

Comment 8

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/7ba35a3bc076
https://hg.mozilla.org/releases/mozilla-beta/rev/705352642b7e
https://github.com/mozilla-firefox/firefox/commit/11e04b612710
https://hg.mozilla.org/releases/mozilla-beta/rev/20e9ed9838a5

Comment 9

[Adina Petridean QA [:apetridean]]

Verified as fixed on the latest Nightly 141.0a1 from 15.06.2025 and Firefox 140.0b9 with Samsung S24 Ultra (Android 15) and Poco M4 Pro (Android 12). As there are no active private tabs, authentication is not required.

Comment 10

[Mike a [:mavduevskiy]]

Attachment: Revert "Bug 1971371 - Part 2: refactor to remove duplicated code"

This reverts commit 27d3153837efcb27c4508bbd22a5da5dc958a5a8.

Comment 11

[Mike a [:mavduevskiy]]

Attachment: Revert "Bug 1971371 - Part 1: Don't lock PBM when the app has focus"

This reverts commit 4eacae557406f986ff075eef16ab44823b6f2b65.

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 13

[Phabricator Automation]

Comment on attachment 9504396 [details]
Revert "Bug 1971371 - Part 2: refactor to remove duplicated code"

Revision D259483 was moved to bug 1980512. Setting attachment 9504396 [details] to obsolete.

Comment 14

[Phabricator Automation]

Comment on attachment 9504397 [details]
Revert "Bug 1971371 - Part 1: Don't lock PBM when the app has focus"

Revision D259484 was moved to bug 1980512. Setting attachment 9504397 [details] to obsolete.

Comment 15

[Mike a [:mavduevskiy]]

no changes to the bug state here; this bug was a regression from 1967448 fix. Now, that the regressor is being reverted, the change addressing this bug is not required and will be reverted as well.

additional context in the reverting bug
https://bugzilla.mozilla.org/show_bug.cgi?id=1980512