1971400 - [Tab Management Phase 1] Implement fullscreen fragment for Tabs Tray

Status: VERIFIED FIXED

(Firefox for Android :: Tabs, task)

Description

[Cathy Lu [:calu]]

Make a V2 fragment that is a regular, fullscreen fragment.
Remove all of the BottomSheet behavior and anything related to the Tabs Tray technically being a dialog.

Make sure this is under a feature flag to keep the existing bottom sheet implementation.

Comment 1

[Noah Bond [:007]]

As part of this work to make the V2 Tabs Tray, also make V2 copies of the existing Tabs Tray Composables

Comment 2

[Noah Bond [:007]]

Attachment: Bug 1971400 - Part 1 - Create new Secure Tab Binding

Comment 3

[Noah Bond [:007]]

Attachment: Bug 1971400 - Part 3 - Transform the Tab Manager from a Dialog into a fullscreen fragment

Comment 4

[Noah Bond [:007]]

Attachment: Bug 1971400 - Part 4 - Remove Bottom-sheet related UI tests and fix test breakages in CollectionTest.kt and HomeScreenTest.kt

Comment 5

[Noah Bond [:007]]

Attachment: Bug 1971400 - Part 2 - Create new Tab Manager Controller files

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1467537f8a0b
https://hg.mozilla.org/integration/autoland/rev/e783e5f27ee8
Part 1 - Create new Secure Tab Binding r=android-reviewers,npoon
https://github.com/mozilla-firefox/firefox/commit/b0a684e59333
https://hg.mozilla.org/integration/autoland/rev/4fa7ba05d9b8
Part 2 - Create new Tab Manager Controller files r=android-reviewers,npoon
https://github.com/mozilla-firefox/firefox/commit/6613e6b8669b
https://hg.mozilla.org/integration/autoland/rev/ec13b27e367a
Part 3 - Transform the Tab Manager from a Dialog into a fullscreen fragment r=android-reviewers,npoon
https://github.com/mozilla-firefox/firefox/commit/1e39b7d7dee6
https://hg.mozilla.org/integration/autoland/rev/72da9abcc60a
Part 4 - Remove Bottom-sheet related UI tests and fix test breakages in CollectionTest.kt and HomeScreenTest.kt r=android-reviewers,aaronmt,npoon

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/842b8f4abdea
https://hg.mozilla.org/integration/autoland/rev/566d7dc84a3d
Revert "Bug 1971400 - Part 4 - Remove Bottom-sheet related UI tests and fix test breakages in CollectionTest.kt and HomeScreenTest.kt r=android-reviewers,aaronmt,npoon" for causing ui-test failures @ HistoryTest

Comment 8

[amarc]

Backed out for causing ui-test failures @ HistoryTest

• Backout link
• Push with failures
• Failure Log

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5e81b64f4ed8
https://hg.mozilla.org/mozilla-central/rev/47d8d7840ccb
Revert "Bug 1971400 - Part 4 - Remove Bottom-sheet related UI tests and fix test breakages in CollectionTest.kt and HomeScreenTest.kt r=android-reviewers,aaronmt,npoon" for causing ui-test failures @ HistoryTest

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e783e5f27ee8
https://hg.mozilla.org/mozilla-central/rev/4fa7ba05d9b8
https://hg.mozilla.org/mozilla-central/rev/ec13b27e367a
https://hg.mozilla.org/mozilla-central/rev/72da9abcc60a

Comment 11

[Noah Bond [:007]]

re-attempting this today

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d4ce3a5003ad
https://hg.mozilla.org/integration/autoland/rev/f5b1dc294dc4
Part 1 - Create new Secure Tab Binding r=android-reviewers,npoon
https://github.com/mozilla-firefox/firefox/commit/cf3075d41be7
https://hg.mozilla.org/integration/autoland/rev/866eb1efe0fb
Part 2 - Create new Tab Manager Controller files r=android-reviewers,npoon
https://github.com/mozilla-firefox/firefox/commit/7e1fbdf186c9
https://hg.mozilla.org/integration/autoland/rev/f3f9aba5d4aa
Part 3 - Transform the Tab Manager from a Dialog into a fullscreen fragment r=android-reviewers,npoon
https://github.com/mozilla-firefox/firefox/commit/f7b98bf10fa7
https://hg.mozilla.org/integration/autoland/rev/78639e9383d2
Part 4 - Remove Bottom-sheet related UI tests and fix test breakages in CollectionTest.kt and HomeScreenTest.kt r=android-reviewers,aaronmt,npoon

Comment 13

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/f5b1dc294dc4
https://hg.mozilla.org/mozilla-central/rev/866eb1efe0fb
https://hg.mozilla.org/mozilla-central/rev/f3f9aba5d4aa
https://hg.mozilla.org/mozilla-central/rev/78639e9383d2

Comment 14

[Noah Bond [:007]]

QE - the Tabs Tray is now fullscreen (on Nightly only). Could we get some additional verification that the Tabs Tray functions as expected and navigating to it (from home, the browser, Bookmarks, and History) and navigating away from it (closing, navigating to Tab Settings (via the three-dot menu), and navigating to Account Settings (via the three-dot menu) works as expected?

Comment 15

[Mira Lobontiu (Android QA)]

Verified on the latest Firefox for Android Nightly 143.0a1 from 7/24 with Samsung Galaxy S9 Ultra (Android 15), Samsung Galaxy S24 (Android 15), and Pixel Tablet (Andorid 15) that:

• the tabs tray navigating to it (from home, the browser, Bookmarks, and History) and navigating away from it functions as expected;
• closing, navigating to tab settings, and navigating to account settings (via the three-dot menu) works as expected.