1971433 - Convert Certificates section to config-based prefs

Status: RESOLVED FIXED

(Firefox :: Settings UI, task)

Description

[Mark Striemer [:mstriemer]]

The Certificates section on the Privacy & Security settings page should be converted to the config-based settings system.

These changes can be made in the existing Privacy & Security page. The end result should be the following settings:

• Query OCSP... checkbox
• Allow Firefox to automatically trust third-party...
• Manage certificates button (opens the existing modal)
• Manage security devices button (opens the existing modal)

The buttons will be box-buttons in the final redesign, but can stay as moz-button elements so they don't look out of place for now (they will move to be on the left, rather than floating on the right though)

There are some open questions in the Figma still:

• Should the buttons be grouped together at the bottom of the card?
• Is there supposed to be a warning message when these settings are turned off?

Comment 1

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1971433 - Convert Certificates section to config-based prefs - r=emz!,#recomp-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/53350bc108bf
https://hg.mozilla.org/integration/autoland/rev/14f24fcd720c
Convert Certificates section to config-based prefs - r=emz,fluent-reviewers,hjones,bolsson

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/72f50387afb6
https://hg.mozilla.org/integration/autoland/rev/3f5ca205df9e
Revert "Bug 1971433 - Convert Certificates section to config-based prefs - r=emz,fluent-reviewers,hjones,bolsson" for causing lint failure on main.js

Comment 4

[Narcis Beleuzu [:NarcisB]]

Backed out for causing lint failure on main.js

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/3f5ca205df9eccca54c5a7fedab5bd33e02bf54a
Log link: https://treeherder.mozilla.org/logviewer?job_id=530316070&repo=autoland&task=JxvFyOYASvSK5kVpJbMKng.0&lineNumber=249

Don`t know if there are caused by the lint but there were also:

1. ReferenceError: gMainPane [failures](ReferenceError: gMainPane)
2. Assertion failure at nsXULElement.cpp
3. failure on browser_glean_metrics_exist.js

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/028e311e8bfc
https://hg.mozilla.org/integration/autoland/rev/6ac85a0f8c36
Convert Certificates section to config-based prefs - r=emz,fluent-reviewers,hjones,bolsson

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6ac85a0f8c36