1971443 - More macOS theme clean-ups.

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P3)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1971443 - Remove macOS only separator appearance. r=#mac-reviewers

It's unused because all our toolbarseparator elements are inside panels
or panelviews with custom styles.

Use the same style as other platforms that don't have it.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1971443 - Remove unused ColorFill() widget info. r=#mac-reviewers

Seems this used to be for vibrancy, but is unused now.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1971443 - Use non-native appearance for listbox on cocoa, and remove CoreUI drawing path. r=#mac-reviewers

It doesn't do anything too special, our non-native drawing is actually nicer.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1971443 - Use a constexpr for kMaxFocusRingWidth. r=#mac-reviewers

Didn't blame this but I guess this used to depend on OS version?

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1971443 - Stop using native rendering for progress/meter/range on cocoa. r=#mac-reviewers

Same reasoning as in
https://bugzilla.mozilla.org/show_bug.cgi?id=1967569#c2 and following.

This also allows simplifying a bit the native appearance rendering of
these in the future. e.g. we don't really need separate appearance
values for these anymore.

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1971443 - Remove unused groupbox widget type. r=#mac-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c702559638ae
https://hg.mozilla.org/integration/autoland/rev/56e5a3c9e3ae
Remove macOS only separator appearance. r=desktop-theme-reviewers,dao

Comment 8

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/56e5a3c9e3ae

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/777020ffdc4c
https://hg.mozilla.org/integration/autoland/rev/3e889cb5a27f
Remove unused ColorFill() widget info. r=mac-reviewers,mstange
https://github.com/mozilla-firefox/firefox/commit/347507e6465f
https://hg.mozilla.org/integration/autoland/rev/f128ab7604c2
Use non-native appearance for listbox on cocoa, and remove CoreUI drawing path. r=mac-reviewers,desktop-theme-reviewers,dao,mstange
https://github.com/mozilla-firefox/firefox/commit/733b12ed8e13
https://hg.mozilla.org/integration/autoland/rev/9a02d8adfe82
Use a constexpr for kMaxFocusRingWidth. r=mac-reviewers,mstange
https://github.com/mozilla-firefox/firefox/commit/ca36c3866126
https://hg.mozilla.org/integration/autoland/rev/b81db8f9f0ba
Remove unused groupbox widget type. r=mac-reviewers,mstange
https://github.com/mozilla-firefox/firefox/commit/7d7d876d6598
https://hg.mozilla.org/integration/autoland/rev/275b63046ac5
Stop using native rendering for progress/meter/range on cocoa. r=mac-reviewers,mstange

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3e889cb5a27f
https://hg.mozilla.org/mozilla-central/rev/f128ab7604c2
https://hg.mozilla.org/mozilla-central/rev/9a02d8adfe82
https://hg.mozilla.org/mozilla-central/rev/b81db8f9f0ba
https://hg.mozilla.org/mozilla-central/rev/275b63046ac5