1971512 - Replace usage of "TimedPromise" with a simple timer in AnimationFramePromise

Status: RESOLVED FIXED

(Remote Protocol :: Agent, task, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

On bug 1947402 the AnimationFramePromise got refactored to allow to escape as well after a given amount of seconds. Therefore the TimedPromise was used to allow an early abort via Promise.race.

As it looks like the usage of the TimedPromise caused a regression because it cannot be canceled when requestAnimationFrame was called or the window was closed or put into BFCache. As such a warning log entry is done causing confusion when observing WebDriver logs or even failing tests that rely on specific log output.

I would suggest that we use a basic timer from the Timer.sys.mjs module instead for the AnimationFramePromise. That way we have a timer id that we can cancel once Promise.race was resolved.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1971512 - [remote] Replace usage of "TimedPromise" with a simple timer in AnimationFramePromise.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This is causing a higher failure rate for Thunderbird so putting it into the m16 milestone.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b20068e69ed4
https://hg.mozilla.org/integration/autoland/rev/363c445425ce
[remote] Replace usage of "TimedPromise" with a simple timer in AnimationFramePromise. r=webdriver-reviewers,jdescottes

Comment 4

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/363c445425ce

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1971512 - [remote] Replace usage of "TimedPromise" with a simple timer in AnimationFramePromise.

Original Revision: https://phabricator.services.mozilla.com/D253321

Comment 6

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Only affects automation with Webdriver causing extra logs and potential xpcshell test failures
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: none
• Risk associated with taking this patch: low
• Explanation of risk level: Replaces a custom timer promise with a plain timer promise
• String changes made/needed: none
• Is Android affected?: yes

Comment 7

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/7af5bc0ba2f3
https://hg.mozilla.org/releases/mozilla-beta/rev/859971911341