1971533 - Converted results are missing from the address bar dropdown when inputs with decimal separators are used

Status: NEW

(Firefox :: Address Bar, enhancement, P3)

Description

[Dana Lucaci, Desktop QA]

Found in

• Nightly 141.a1

Affected versions

• Nightly 141.a1
• Beta 140.0b7

Tested platforms

• Affected platforms: Windows 10, macOS 14, Ubuntu 22

Preconditions

• browser.urlbar.unitConversion.enabled is set to true

Steps to reproduce

1. Type "10,000kg to t" into the URL bar.
2. Open a new tab and type "200000kn in n" into the URL bar.
3. Observe the converted results in the address bar drop down.

Expected result

• The syntax is correctly converted and the result is displayed in the address bar dropdown (step 1).
• The result is correctly displayed in the address bar dropdown, with decimals consistently separated by either a comma or a dot (Step 2).

Actual result

• The syntax is not converted and the result is missing from the address bar dropdown (step 1).
• The result is displayed in the address bar, but the decimals are not separated by either a comma or a dot. (Step 2).

Regression range

• Not a reggresion.

Comment 1

[Drew Willcoxon :adw]

This is a nice-to-have for sure, and IMO it's more of an enhancement request than a defect.

Digit grouping is different in different locales, both the characters that are used for grouping and how many digits are grouped. CJK languages also have non-punctuation grouping characters. We should look into existing unicode support in Firefox/Gecko for parsing locale-specific numbers -- maybe ICU, similar to bug 1729248. And/or a good place to start might be to at least ignore punctuation in search strings that otherwise match unit-conversion intent.