Closed Bug 1971756 Opened 7 months ago Closed 6 months ago

[wpt-sync] Sync PR 53035 - [Gap Decorations]: Invalidate Paint when GapGeometry changes

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
142 Branch
Tracking Flags:
Tracking Status
firefox142 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 53035 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/53035
Details from upstream follow.

Sam Davis Omekara (from Dev Box) <samomekarajr@microsoft.com> wrote:

[Gap Decorations]: Invalidate Paint when GapGeometry changes

This CL addresses a bug in the grid gap decorations logic where
decorations were not repainted when the grid structure changed
dynamically. For example, when new tracks are introduced as a result of
added grid items, the gap decorations fail to render in the newly
created gaps unless a full paint invalidation is triggered forcefully
(e.g. window resize).

To resolve this, this change ensures that paint is invalidated (via
SetShouldDoFullPaintInvalidation) whenever a child is added to or
removed from the grid. This guarantees that gap decorations are
correctly updated to reflect the current grid layout.

Fixed: 423663305
Bug: 357648037
Change-Id: I6d5b045440ebc4f0143c229ee423685b2507b3bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6625941
Reviewed-by: Ian Kilpatrick \<ikilpatrick@chromium.org>
Commit-Queue: Sam Davis Omekara \<samomekarajr@microsoft.com>
Reviewed-by: Kurt Catti-Schmidt \<kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1471512}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

https://hg.mozilla.org/mozilla-central/rev/efcad6e03b9b
https://hg.mozilla.org/mozilla-central/rev/7a47a5210fc7

Status: NEW → RESOLVED
Closed: 6 months ago
status-firefox142: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 142 Branch
You need to log in before you can comment on or make changes to this bug.