1971783 - [wpt-sync] Sync PR 53034 - layout: Floor free space by 0 in solve_inline_margins_avoiding_floats()

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 53034 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/53034
Details from upstream follow.

Oriol Brufau <[e-mail]> wrote:

layout: Floor free space by 0 in solve_inline_margins_avoiding_floats()

PlacementAmongFloats should guarantee that the inline size of the placement rect is at least as big as the inline size of the box, resulting in a non-negative free space.

However, that may fail when dealing with huge sizes that need to be saturated to MAX_AU, so this floors the free space by zero.

Testing: New crashtest
Fixes: #<!-- nolink -->37312

Reviewed in servo/servo#37362

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=96911550edaab0551144d9ed413efac8fad4442c

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS : 1

Chrome

PASS : 1

Safari

CRASH: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/84bb9f9b9b9e
https://hg.mozilla.org/integration/autoland/rev/bb6333ae99b4
[wpt PR 53034] - layout: Floor free space by 0 in solve_inline_margins_avoiding_floats(), a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/bb6333ae99b4