1971791 - [wpt-sync] Sync PR 53021 - [layout] Fix AddChildBeforeDescendant for LayoutBlock.

Status: NEW

(Core :: Layout: Grid, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 53021 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/53021
Details from upstream follow.

Ian Kilpatrick <[e-mail]> wrote:

[layout] Fix AddChildBeforeDescendant for LayoutBlock.

LayoutBlock handles the adding/removing children for
grid/flex/table-parts/etc.

AddChildBeforeDescendant previously was called from
LayoutBlockFlow::AddChild and LayoutBlock::AddChild, however there are
subtly different rules for both of them.

For grid/flex/etc, when inserting an OOF-positioned element, it should
split any anonymous blocks, and add the OOF-positioned at the top level.
We weren't previously doing this - instead we were adding it directly to
the anonymous block-flow.

As the rules are slightly different, split AddChildBeforeDescendant into
two private methods on each.

Bug: 40560663
Change-Id: I5fffe9597314c9d98dc499ab46b24ecd5a55aad2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6626458
Reviewed-by: David Grogan \<[e-mail]>
Reviewed-by: Morten Stenshorne \<[e-mail]>
Commit-Queue: Ian Kilpatrick \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1471901}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f819534977e2a43af73c2faf9a548c5062e3d887

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base