1971828 - [wpt-sync] Sync PR 53060 - Fix CalculationExpressionOperationNode::CreateSimplified multiply case

Status: NEW

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 53060 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/53060
Details from upstream follow.

Fredrik Söderquist <[e-mail]> wrote:

Fix CalculationExpressionOperationNode::CreateSimplified multiply case

Since there are more types than "operations" and number/pixel-percent
these days, the type checking wasn't strict enough - for example color
keywords could cause incorrect casting in some cases. Adjust the
pre-condition to check both LHS and RHS to match the assumptions in the
rest of the code.

Fixed: 422982562
Change-Id: Iccedc253c87e1d41fe9bb4134ef2cb7019685512
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6630498
Reviewed-by: Daniil Sakhapov \<[e-mail]>
Auto-Submit: Fredrik Söderquist \<[e-mail]>
Commit-Queue: Daniil Sakhapov \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1472269}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=602ef41c1e84b53cbf7b212ed78b578bd9a60110

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1073 subtests

Status Summary

Firefox

OK : 1
PASS : 1072
FAIL : 1

Chrome

CRASH: 1

Safari

OK : 1
PASS : 1072
FAIL : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-color/parsing/color-computed-relative-color.html [wpt.fyi]
  • Property color value 'LCH(from var(--accent) l c calc(h + 180 * sibling-index()))': FAIL (Safari: FAIL)