1971995 - [wpt-sync] Sync PR 53112 - HasAnchorEvaluator should not be considered for diffing

Status: NEW

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 53112 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/53112
Details from upstream follow.

Rune Lillesveen <[e-mail]> wrote:

HasAnchorEvaluator should not be considered for diffing

HasAnchorEvaluator flag was part of style diffing, which meant there was
always a diff between the standard recalc and the interleaved one. In
particular that made a difference for highlight styles which triggers a
recalc for children in the interleaved style recalc.

The interleaved recalc for anchored element descendants during layout is
a more general problem. Currently, it affects transitions of explicitly
inherited properties which are allowed to change for position-try
fallbacks, but with anchored() container queries it will become a more
general issue which needs to be addressed for ShouldStoreOldStyle() in
StyleResolver.

Make the ComputedStyle field custom_compare to avoid diffs for
HasAnchorEvaluator.

Bug: 409220513
Change-Id: I6581ec6097f4fabcafcd63606558f3cca8a886aa
Reviewed-on: https://chromium-review.googlesource.com/6641261
WPT-Export-Revision: ac621b587f7080f69ac116dd52a09092cf580e44

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=c82d3308503773d4b49c0a33ec8d97541f81cb05

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
PASS: 1

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base