Open Bug 1972050 Opened 7 days ago Updated 1 day ago

[wpt-sync] Sync PR 53084 - [Gap Decorations]: Avoid empty GapGeometry for flex

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

People

(Reporter: wpt-sync, Unassigned)

References

(Depends on 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 53084 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/53084
Details from upstream follow.

Sam Davis Omekara (from Dev Box) <samomekarajr@microsoft.com> wrote:

[Gap Decorations]: Avoid empty GapGeometry for flex

This CL addresses a bug in the flex gap implementation where GapGeometry
was being constructed with empty data. This caused a CHECK failure and a
crash during Ink Overflow computation. The fix ensures that we return
nullptr when main and cross axis intersections are empty, preventing the
crash.

Bug: 357648037, 422596228
Change-Id: I0c4c6a7b55b3b2a5edc396e09ef3658927759c1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6630612
Reviewed-by: Ian Kilpatrick \<ikilpatrick@chromium.org>
Commit-Queue: Sam Davis Omekara \<samomekarajr@microsoft.com>
Reviewed-by: Javier Contreras \<javiercon@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1472719}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS : 1

Chrome

CRASH: 1

Safari

PASS : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

You need to log in before you can comment on or make changes to this bug.