1972051 - [wpt-sync] Sync PR 53088 - Implement base appearance select multiple popup

Status: NEW

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 53088 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/53088
Details from upstream follow.

Joey Arhar <[e-mail]> wrote:

Implement base appearance select multiple popup

This patch implements several behaviors:

1. Changes logic to determine whether \<select multiple> should be a
   MenuList or Listbox to be the same across platforms. No size
   attribute will be ListBox, explicit size=1 will make it MenuList, and
   all other size values are ListBox. I proposed this here:
   https://github.com/whatwg/html/issues/8189#issuecomment-2877242732
2. Implements a MenuList \<select multiple> on desktop by reusing the
   appearance:base-select popover. This means that the popover is not
   only used when the \<select> has appearance:base-select, but also if
   it is appearance:auto on desktop with the multiple attribute.
3. Adds UA styles for base appearance \<select multiple> with popup.

The UA stylesheet for appearance:auto \<select multiple> with popup will
need more work as a followup, it looks bad with this patch.

Bug: 357649033
Change-Id: Ia6e7a608c78b26e7ad8105fde61537cb524d7bcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6546616
Commit-Queue: Joey Arhar \<[e-mail]>
Reviewed-by: Mason Freed \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1472738}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=206097334b56a31585f7caee83497e0dfee69e07

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests

Status Summary

Firefox

OK : 3
PASS : 7
FAIL : 2

Chrome

OK : 3
PASS : 7
FAIL : 3

Safari

OK : 3
PASS : 7
FAIL : 2
TIMEOUT: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/semantics/forms/the-select-element/customizable-select-multiple-popup/select-multiple-popup-keyboard-behavior.tentative.html [wpt.fyi]
  • Keyboard behavior for base appearance <select multiple size=1>: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/semantics/forms/the-select-element/customizable-select-multiple-popup/select-multiple-popup-mouse-behavior.tentative.html [wpt.fyi]
  • Mouse behavior for base appearance <select multiple size=1>: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/semantics/forms/the-select-element/customizable-select-multiple-popup/select-multiple-popup-appearance.tentative.html [wpt.fyi]: SKIP (Chrome: FAIL, Safari: TIMEOUT)

Tests Disabled in Gecko Infrastructure

• /html/semantics/forms/the-select-element/customizable-select-multiple-popup/select-multiple-popup-appearance.tentative.html [wpt.fyi]: SKIP (Chrome: FAIL, Safari: TIMEOUT)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/46f2a46d50c3
https://hg.mozilla.org/integration/autoland/rev/4be13a4459cd
[wpt PR 53088] - Implement base appearance select multiple popup, a=testonly
https://github.com/mozilla-firefox/firefox/commit/f42a8a2b6656
https://hg.mozilla.org/integration/autoland/rev/cf3499c9e2c7
[wpt PR 53088] - Update wpt metadata, a=testonly