Closed Bug 1972065 Opened 1 year ago Closed 2 months ago

Add missing session data types for viewport and geolocation overrides

Categories

(Remote Protocol :: Agent, task, P3)

task

Tracking

(firefox153 fixed)

RESOLVED FIXED
153 Branch
Tracking Status
firefox153 --- fixed

People

(Reporter: jdescottes, Assigned: khalid.alhaddad98)

Details

(Whiteboard: [webdriver:m20][webdriver:external])

Attachments

(1 file)

We should normally declare new Session Data types in https://searchfox.org/mozilla-central/rev/99f02d7a9456d4cfe2abd9c2a4a1eb8f3f41e22a/remote/shared/messagehandler/sessiondata/SessionData.sys.mjs#29-32

export const SessionDataCategory = {
  Event: "event",
  PreloadScript: "preload-script",
};

but we haven't done that for viewport and geolocation overrides, and we also aren't using it explicitly for preload scripts: https://searchfox.org/mozilla-central/search?q=category%3A+%22&path=remote%2F**%2Fmodules&case=false&regexp=false

Points: --- → 1
Priority: -- → P3
Whiteboard: [webdriver:backlog]
Assignee: nobody → khalid.alhaddad98
Status: NEW → ASSIGNED
Attachment #9589416 - Attachment description: Bug 1972065 - Add missing session data types for viewport and geolocation overrides. r?jdescottes → Bug 1972065 - Add new categories to SessionData module to be used instead of hardcoded strings. r?jdescottes
Pushed by jdescottes@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/adeb257729ee https://hg.mozilla.org/integration/autoland/rev/f58f6dd58b91 Add new categories to SessionData module to be used instead of hardcoded strings. r=jdescottes
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch
Whiteboard: [webdriver:backlog] → [webdriver:m20][webdriver:external]
Points: 1 → ---
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: