Closed Bug 1972082 Opened 7 months ago Closed 2 days ago

Convert Website languages to config-based prefs box group

Categories

(Firefox :: Settings UI, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
149 Branch
Tracking Status
firefox149 --- fixed

People

(Reporter: mstriemer, Assigned: tgiles)

References

(Blocks 4 open bugs)

Details

(Whiteboard: [recomp])

Attachments

(2 files, 3 obsolete files)

Create a box-group that replaces the existing Webpage Language Settings dialog.

This is an enhancement on bug 1972081 which moves the language management into the top-level page and out of its existing dialog.

https://www.figma.com/design/2b02v18AppIpsTceWac2T3/Settings-Desktop?node-id=6755-16045&t=QyyPgM3bfhGhjKIE-4

Assignee: nobody → tgiles
Severity: -- → N/A
Status: NEW → ASSIGNED
Priority: -- → P3

init commit

Fix the website language setting group not rendering

update l10nId for language picker wrapper

Attachment #9530380 - Attachment description: WIP: Bug 1972082 - setting controls not created → WIP: Bug 1972082 - setting controls correctly rendering

I'm not sure how to make the config work with the designed layout.
It seems like adding controls breaks the reorderable box since
the markup goes: moz-box-group > setting-control > moz-box-item.

I'm sure I'm just not writing the config in the correct way,
especially as the reorderable box items are going to be
dynamically generated anyway.

Attachment #9530406 - Attachment is obsolete: true
Attachment #9530380 - Attachment description: WIP: Bug 1972082 - setting controls correctly rendering → WIP: Bug 1972082 - Add scaffolding for new website languages design
Blocks: 2006431
Attachment #9533777 - Attachment is obsolete: true
Attachment #9530380 - Attachment description: WIP: Bug 1972082 - Add scaffolding for new website languages design → WIP: Bug 1972082 - Convert Website languages to config-based box group. r=#recomp-reviewers

squash: start fixing test_moz_box_group.html

I don't think I've implemented the wrapper element correctly because the
moz-reorderable-list logic is preventing the 'reorder' event from
firing.

Attachment #9537243 - Attachment is obsolete: true
Depends on: 2010132
Attachment #9530380 - Attachment description: WIP: Bug 1972082 - Convert Website languages to config-based box group. r=#recomp-reviewers → Bug 1972082 - Convert Website languages to config-based box group. r=#recomp-reviewers,#translations-reviewers
Blocks: 2011976
Blocks: 2011980
Pushed by tgiles@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/c8e458b97278 https://hg.mozilla.org/integration/autoland/rev/397d4239c8df Convert Website languages to config-based box group. r=fluent-reviewers,akulyk,bolsson
Status: ASSIGNED → RESOLVED
Closed: 2 days ago
Resolution: --- → FIXED
Target Milestone: --- → 149 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: