1972100 - Cannot download translated PDF files from Google Translate

Status: VERIFIED FIXED

(Web Compatibility :: Site Reports, defect, P1)

Description

[Krzysztof Sadowski]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:140.0) Gecko/20100101 Firefox/140.0

Steps to reproduce:

What did you do?

I used Google Translate (https://translate.google.pl/?sl=en&tl=pl&op=translate) to upload and translate a PDF file.

After the translation finished, I clicked the "Download" button ("Pobierz").

What happened?

Nothing happened — the file did not download. No download dialog appeared.

What did you expect?

The translated PDF should be downloaded, like it does in Chrome and stable Firefox.

Affected version:

• Firefox 140.0b8 (and earlier betas, e.g. 140.0b1)
• OS: [Twoja dystrybucja/system np. Ubuntu 24.04 / Windows 11]

Notes:

• In Firefox 127 stable: ✅ works
• In Chrome: ✅ works
• In Firefox 140 beta: ❌ broken
• Same result in Safe Mode and clean profile

Console output:

"JavaScript warning: unreachable code after return statement"
appears multiple times from an injected script.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Krzysztof Sadowski]

I think this may be misclassified. The issue only affects downloading a translated PDF in Google Translate, not general GTK UI behavior. It works in Firefox stable and Chrome. Possibly related to CSP, download handling, or scripting behavior.

Comment 3

[Krzysztof Sadowski]

Affected version:

• Firefox 140.0b8 (and earlier betas, e.g. 140.0b1)
• OS (tested on multiple Linux distros):
  • Debian 12 Bookworm
  • Ubuntu 24.04 Noble Numbat
  • Linux Mint 22.1
  • MX Linux 23.6
  • SparkyLinux 7.7
  • LinuxQ83 Chopin 12.11

Comment 4

[Dennis Schubert [:denschub]]

Krzysztof, since you claim this is a regression, would you be willing to help us figure out what change exactly broke it? There's a tool called mozregression that allows you to somewhat easily do that, check the linked website for instructions. That would help us a lot! :)

Comment 5

[Krzysztof Sadowski]

Zewnętrzny html
<button class="VfPpkd-LgbsSe VfPpkd-LgbsSe-OWXEXe-INsAgc VfPpkd-LgbsSe-OWXEXe-Bz112c-M1Soyc Rj2Mlf OLiIxf PDpWxe LQeN7 sWFiQe" jscontroller="soHxf" jsaction="click:cOuCgd(preventDefault=true); mousedown:UX7yZ; mouseup:lbsD7e; mouseenter:tfO1Yc; mouseleave:JywGue; touchstart:p6p2H; touchmove:FwuNnf; touchend:yfqBxc; touchcancel:JMtRjd; focus:AHmuwe; blur:O22p3e; contextmenu:mg9Pef;mlnRJb:fLiPzd" data-idom-class="Rj2Mlf OLiIxf PDpWxe LQeN7 sWFiQe" jsname="hRZeKc" jslog="172762; track:JIbuQc;" style="--mdc-ripple-fg-size: 116px; --mdc-ripple-fg-scale: 1.7899973566985323; --mdc-ripple-fg-translate-start: 15.91668701171875px, -32px; --mdc-ripple-fg-translate-end: 39.16667175292969px, -40px;"><div class="VfPpkd-Jh9lGc"></div><div class="VfPpkd-J1Ukfc-LhBDec"></div><span class="notranslate VfPpkd-kBDsod uzHXHc" aria-hidden="true"><svg focusable="false" width="18" height="18" viewBox="0 0 24 24" class=" NMm5M"><path d="M4 15h2v3h12v-3h2v3c0 1.1-.9 2-2 2H6c-1.1 0-2-.9-2-2m11.59-8.41L13 12.17V4h-2v8.17L8.41 9.59 7 11l5 5 5-5-1.41-1.41z"></path></svg></span><span jsname="V67aGc" class="VfPpkd-vQzf8d">Pobierz tłumaczenie</span></button>

selektor css
button.VfPpkd-LgbsSe:nth-child(2)

ścieżka css
html body#yDmH0d.tQj5Y.ghyPEc.IqBfM.ecJEib.EWZcud.EIlDfe.cjGgHb.d8Etdd.LcUz9d c-wiz.zQTmif.SSPGKf.kXN2zb.BIdYQ div.T4LgNb div.ToWKne c-wiz.MOkH4e.yF6Zo.MFKVse div.R5HjH c-wiz.k5v5Nb div.oLbzv c-wiz div.eTNoGb div div.RiZzuc div.ld4Jde div.PEVemc.FTPuBd button.VfPpkd-LgbsSe.VfPpkd-LgbsSe-OWXEXe-INsAgc.VfPpkd-LgbsSe-OWXEXe-Bz112c-M1Soyc.Rj2Mlf.OLiIxf.PDpWxe.LQeN7.sWFiQe

xpatch
/html/body/c-wiz/div/div[2]/c-wiz/div[3]/c-wiz/div[2]/c-wiz/div/div[1]/div/div[2]/div/button[1]

Comment 6

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

I got this regressor: Bug 1941725, which looks suspicious, yes.
However, to be more specific,mozregresson tool gave me this phab commit: https://phabricator.services.mozilla.com/D245896 It's the "test case" for Bug 1941725 that is a bit weird.

Comment 7

[Andreas Farre [:farre]]

This is the regression window

Comment 8

[Andreas Farre [:farre]]

Try: https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=138512

Comment 9

[Andreas Farre [:farre]]

Attachment: Bug 1972100 - Only block sandboxed pdfs handled internally. r=smaug!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ab96dce96303
https://hg.mozilla.org/integration/autoland/rev/9c1877ae5a69
Only block sandboxed pdfs handled internally. r=smaug

Comment 11

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/9c1877ae5a69

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1941725

Comment 13

[Andreas Farre [:farre]]

Comment on attachment 9496263 [details]
Bug 1972100 - Only block sandboxed pdfs handled internally. r=smaug!

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Translating PDFs on Google Translate is broken.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See STRs
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small change covered by tests.
• String changes made/needed:
• Is Android affected?: No

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Google Translate is broken.
• User impact if declined: Translating PDFs on Google Translate is broken.
• Fix Landed on Version: 142
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small change covered by tests.

Comment 14

[Peter Magyari (Desktop QA)]

I have reproduced the issue using Firefox 141.0a1 (20250623065250) on Win10, Ubuntu 24.04 and MacOS 15.5 and verified the fix using 142.0a1 (20250624211752).

Comment 15

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/5d29322fd3e1
https://hg.mozilla.org/releases/mozilla-beta/rev/00cbab992aa8

Comment 16

[Peter Magyari (Desktop QA)]

Verified fixed on Beta 141.0b5 (20250701164013).

Comment 17

[Krzysztof Sadowski]

In the beta version 141.0b5 it is good, PDF downloads from www.translate.google.com works

Comment 18

[Donal Meehan [:dmeehan]]

Comment on attachment 9496263 [details]
Bug 1972100 - Only block sandboxed pdfs handled internally. r=smaug!

Approved for 140.0.4

Comment 19

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/f996624713bf
https://hg.mozilla.org/releases/mozilla-release/rev/883794279140

Comment 20

[Peter Magyari (Desktop QA)]

Verified fixed on Firefox 140.0.4 (20250703182918).

Comment 21

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr140/rev/ae62c57ac828

Comment 22

[Donal Meehan [:dmeehan]]

Comment on attachment 9496263 [details]
Bug 1972100 - Only block sandboxed pdfs handled internally. r=smaug!

Approved for 140.1esr

Comment 23

[Peter Magyari (Desktop QA)]

Verified fixed on ESR 140.1.0 (20250708174826)