Closed
Bug 1972125
Opened 6 months ago
Closed 4 months ago
Null check designMode in context menu
Categories
(SeaMonkey :: General, defect)
SeaMonkey
General
Tracking
(seamonkey2.53+ fixed)
RESOLVED
FIXED
Future
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.22)
Attachments
(1 file)
|
1.05 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
We should check that designMode exists on ownerDocument before checking what it is set to.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: occasional errors in console
Testing completed (on m-c, etc.): 2.53.22pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
Attachment #9494721 -
Flags: review?(frgrahl)
Attachment #9494721 -
Flags: approval-comm-release?
|
||
Updated•4 months ago
|
|
|
||
Comment 2•4 months ago
|
||
Comment on attachment 9494721 [details] [diff] [review]
1972125-context-designMode-25322.patch
LGTM r/a+
Attachment #9494721 -
Flags: review?(frgrahl)
Attachment #9494721 -
Flags: review+
Attachment #9494721 -
Flags: approval-comm-release?
Attachment #9494721 -
Flags: approval-comm-release+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/2967d2aa4d36
Null check designMode in context menu. r=frg DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
|
|
||
Comment 4•1 month ago
|
||
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/9a85b0e34838485280472bdf60da527771b3b79e
Null check designMode in context menu. r=frg a=frg
You need to log in
before you can comment on or make changes to this bug.
Description
•