1972134 - [wpt-sync] Sync PR 53103 - Don't simplify typed arithmetic expressions during ToCalc()

Status: NEW

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 53103 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/53103
Details from upstream follow.

Daniil Sakhapov <[e-mail]> wrote:

Don't simplify typed arithmetic expressions during ToCalc()

Check if arithmetic expression can be simplified to pixels
and percents type when converting CSSMathExpressionNode to
CalculationExpressionNode.

Also this CL removes type checking for CalculationExpressionNode
as it's not possible to express intermediate types without copying
the logic from CSSMathType, and the type checking is done during
parsing of CSSMathExpressionNode anyway. That type checking has been
done only with DCHECKs on.

Bug: 40768696
Change-Id: Ifd9804b70ce710076b5754523e4ab4a06831e38d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6635293
Commit-Queue: Daniil Sakhapov \<[e-mail]>
Reviewed-by: Anders Hartvoll Ruud \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1472986}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=8754dd53f10991d3d1ccf72f771bcd949bb26b61

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 6 subtests

Status Summary

Firefox

OK : 1
FAIL: 6

Chrome

OK : 1
FAIL: 6

Safari

OK : 1
PASS: 5
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-values/getComputedStyle-calc-mixed-units-003.html [wpt.fyi]
  • testing width: calc(5px * 10lh / 1px): FAIL (Chrome: FAIL, Safari: PASS)
  • testing width: calc(20% * 0.5em / 1px): FAIL (Chrome: FAIL, Safari: PASS)
  • testing width: calc(4px * 4em / 1px): FAIL (Chrome: FAIL, Safari: PASS)
  • testing width: calc(400px / 4lh * 1px): FAIL (Chrome: FAIL, Safari: PASS)
  • testing width: calc(20% / 0.5em * 1px): FAIL (Chrome: FAIL, Safari: PASS)
  • testing width: calc(52px * 1px / 10%): FAIL (Chrome: FAIL, Safari: FAIL)