Open Bug 1972135 Opened 6 days ago Updated 2 hours ago

[wpt-sync] Sync PR 53104 - Translator API: Prevent GC while streaming response

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(Not tracked)

People

(Reporter: wpt-sync, Unassigned)

References

(Depends on 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 53104 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/53104
Details from upstream follow.

Mike Wasserman <msw@chromium.org> wrote:

Translator API: Prevent GC while streaming response

Keep a persistent reference to the session instance while streaming.
Parallels crrev.com/c/6619540 and crrev.com/c/6624962

Fixed: 423799625
Test: Automated; manual bug repro no longer occurs
Change-Id: I7b2003a29756351e3f2d866ecbd6db8850b9dfb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6638912
Reviewed-by: Christine Hollingsworth \<christinesm@chromium.org>
Auto-Submit: Mike Wasserman \<msw@chromium.org>
Commit-Queue: Christine Hollingsworth \<christinesm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1473038}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 17 subtests

Status Summary

Firefox

FAIL : 12
TIMEOUT: 1
ERROR : 1
NOTRUN : 4

Chrome

TIMEOUT: 2
NOTRUN : 16

Safari

FAIL : 12
TIMEOUT: 1
ERROR : 1
NOTRUN : 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /ai/translator/translator.optional.https.window.html [wpt.fyi]: ERROR (Chrome: TIMEOUT, Safari: ERROR)
    • Translator.create() requires user activation when availability is "downloadable.: FAIL (Chrome: TIMEOUT, Safari: FAIL)
    • Simple Translator.translate() call: FAIL (Chrome: NOTRUN, Safari: FAIL)
    • Simple Translator.translateStreaming() call: FAIL (Chrome: NOTRUN, Safari: FAIL)
    • Translate Streaming API must continue even after GC has been performed.: FAIL (Chrome: NOTRUN, Safari: FAIL)
    • Translator: sourceLanguage and targetLanguage are equal to their respective option passed in to Translator.create.: FAIL (Chrome: NOTRUN, Safari: FAIL)
    • Translator.create() call with an aborted signal.: FAIL (Chrome: NOTRUN, Safari: FAIL)
    • Aborting Translator.create().: FAIL (Chrome: NOTRUN, Safari: FAIL)
    • Translator.translate() call with an aborted signal.: FAIL (Chrome: NOTRUN, Safari: FAIL)
    • Aborting Translator.translate().: FAIL (Chrome: NOTRUN, Safari: FAIL)
    • Calling Translator.destroy() aborts calls to translate and measureInputUsage.: FAIL (Chrome: NOTRUN, Safari: FAIL)
    • Translator.create()'s abort signal destroys its Translator after creation.: FAIL (Chrome: NOTRUN, Safari: FAIL)
    • Translator.create() notifies its monitor on downloadprogress: FAIL (Chrome: NOTRUN, Safari: FAIL)
    • Progress events are not emitted after aborted.: TIMEOUT (Chrome: NOTRUN, Safari: TIMEOUT)
    • Translator.translate() echoes non-translatable content: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
    • Translator.measureInputUsage() and inputQuota basic usage.: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
    • Translator.measureInputUsage() call with an aborted signal.: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
    • Aborting Translator.measureInputUsage().: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
You need to log in before you can comment on or make changes to this bug.