1972319 - Disable checking for remote encoder support in GPU process unless pref enabled

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Andrew Osmond [:aosmond] (he/him)]

This will temporarily solve the rise in crashes/hangs.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1972319 - Only check encoder support in GPU process if remote encoding enabled.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/333894c95d42
https://hg.mozilla.org/integration/autoland/rev/1a3dc7a8a0ba
Only check encoder support in GPU process if remote encoding enabled. r=media-playback-reviewers,alwu

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1a3dc7a8a0ba

Comment 4

[Andra Esanu (needinfo me)]

(In reply to Pulsebot from comment #2)

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/333894c95d42
https://hg.mozilla.org/integration/autoland/rev/1a3dc7a8a0ba
Only check encoder support in GPU process if remote encoding enabled.
r=media-playback-reviewers,alwu

Perfherder has detected a talos performance change from push 1a3dc7a8a0ba34c907b4253f9cd6d13752fd0a0e.

If you have any questions, please reach out to a performance sheriff. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
2%	startup_about_home_paint_cached	windows11-64-24h2-shippable	e10s fission stylo webrender	465.06 -> 453.67

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a performance sheriff to do that for you.

You can run all of these tests on try with ./mach try perf --alert 45774

The following documentation link provides more information about this command.