1972342 - Web appearance using missing CSS variable --in-content-box-background-color

Status: RESOLVED FIXED

(Toolkit :: Preferences, defect, P3)

Description

[Henry Wilkes (they/them) [:henry-x]]

After the changes in bug 1865371, .web-appearance-choice should be using --background-color-box, but it is still using --in-content-box-background-color. This has a noticeable effect in the dark theme.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1865371

Comment 2

[Jacqueline Amherst [:jqln]]

Attachment: Bug 1972342 - change --in-content-box-background-color to --background-color-box r?akulyk!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/02cf64446221
https://hg.mozilla.org/integration/autoland/rev/f16bd398c6e7
change --in-content-box-background-color to --background-color-box r=akulyk,settings-reviewers,desktop-theme-reviewers,hjones

Comment 4

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/f16bd398c6e7

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jacqueline.amherst, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox142 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Jacqueline Amherst [:jqln]]

This isn’t critical for 142, would you mind setting status-firefox142 to wontfix? I don't have permission to do it!

Comment 8

[Henry Wilkes (they/them) [:henry-x]]

Comment on attachment 9499239 [details]
Bug 1972342 - change --in-content-box-background-color to --background-color-box r?akulyk!

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is a regression from ESR 128. This also effects Tor Browser, which uses the web-appearance-choice class. I know ESR 140 was just marked as wontfix, but I hope you might reconsider.
• User impact if declined: The website appearance selector background is darker than intended in the dark theme.
• Fix Landed on Version: 143
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only changes one line of CSS.

Comment 9

[Henry Wilkes (they/them) [:henry-x]]

(In reply to Henry Wilkes (they/them) [:henry-x] from comment #8)

This is a regression from ESR 128

Actually, this is not true. ESR 128 used --in-content-box-background-color, rather than --in-content-box-background, which was also undefined.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9499239 [details]
Bug 1972342 - change --in-content-box-background-color to --background-color-box r?akulyk!

Approved for 140.3esr.

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr140/rev/334ba24a5f47