197237 - Trunk crash [@ RDFServiceImpl::GetResource]

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[Jay Patel [:jay]]

These crashes started with 3/12 MozillaTrunk builds.  A similar crash?  with the
same stack signature was fixed recently (see bug 196094).  Here is the latest
Talkback data for these new crashes:

     Count   Offset    Real Signature
[ 19   RDFServiceImpl::GetResource 8ed50b55 - RDFServiceImpl::GetResource ]
[ 3   RDFServiceImpl::GetResource a92bc061 - RDFServiceImpl::GetResource ]
[ 2   RDFServiceImpl::GetResource 6a887ba6 - RDFServiceImpl::GetResource ]
[ 1   RDFServiceImpl::GetResource ca638e38 - RDFServiceImpl::GetResource ]
[ 1   RDFServiceImpl::GetResource c44152b4 - RDFServiceImpl::GetResource ]
[ 1   RDFServiceImpl::GetResource c36a40ea - RDFServiceImpl::GetResource ]
[ 1   RDFServiceImpl::GetResource 20859704 - RDFServiceImpl::GetResource ]
 
     Crash date range: 2003-03-12 to 2003-03-13
     Min/Max Seconds since last crash: 0 - 124
     Min/Max Runtime: 1 - 194
 
     Count   Platform List 
     25   Windows NT 5.1 build 2600
     1   Windows 98 4.90 build 73010104
     1   Windows 98 4.10 build 67766446
     1   Windows 98 4.10 build 67766222
 
     Count   Build Id List 
     28   2003031216
 
     No of Unique Users        18
 
 Stack trace(Frame) 

	 RDFServiceImpl::GetResource
[c:/builds/seamonkey/mozilla/rdf/base/src/nsRDFService.cpp  line 992] 
	 XPTC_InvokeByIndex
[c:/builds/seamonkey/mozilla/xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp 
line 102] 
	 XPCWrappedNative::CallMethod
[c:/builds/seamonkey/mozilla/js/src/xpconnect/src/xpcwrappednative.cpp  line 2025] 
	 XPC_WN_CallMethod
[c:/builds/seamonkey/mozilla/js/src/xpconnect/src/xpcwrappednativejsops.cpp 
line 1293] 
	 js_Invoke	[c:/builds/seamonkey/mozilla/js/src/jsinterp.c  line 845] 
	 js_Interpret	[c:/builds/seamonkey/mozilla/js/src/jsinterp.c  line 2829] 
	 js_Execute	[c:/builds/seamonkey/mozilla/js/src/jsinterp.c  line 1040] 
	 JS_ExecuteScript	[c:/builds/seamonkey/mozilla/js/src/jsapi.c  line 3281] 
	 nsJSContext::ExecuteScript
[c:/builds/seamonkey/mozilla/dom/src/base/nsJSEnvironment.cpp  line 866] 
	 nsXULDocument::ExecuteScript
[c:/builds/seamonkey/mozilla/content/xul/document/src/nsXULDocument.cpp  line 5859] 
	 nsXULDocument::OnStreamComplete
[c:/builds/seamonkey/mozilla/content/xul/document/src/nsXULDocument.cpp  line 5795] 
	 nsStreamLoader::OnStopRequest
[c:/builds/seamonkey/mozilla/netwerk/base/src/nsStreamLoader.cpp  line 144] 
	 nsJARChannel::OnStopRequest
[c:/builds/seamonkey/mozilla/netwerk/protocol/jar/src/nsJARChannel.cpp  line 653] 
	 nsCOMPtr_base::assign_with_AddRef
[c:/builds/seamonkey/mozilla/xpcom/glue/nsCOMPtr.cpp  line 71] 
	 nsInputStreamPump::OnStateStop
[c:/builds/seamonkey/mozilla/netwerk/base/src/nsInputStreamPump.cpp  line 471] 
	 nsInputStreamPump::OnInputStreamReady
[c:/builds/seamonkey/mozilla/netwerk/base/src/nsInputStreamPump.cpp  line 325] 
	 nsInputStreamReadyEvent::EventHandler
[c:/builds/seamonkey/mozilla/xpcom/io/nsStreamUtils.cpp  line 112] 
	 PL_HandleEvent	[c:/builds/seamonkey/mozilla/xpcom/threads/plevent.c  line 664] 
	 PL_ProcessPendingEvents	[c:/builds/seamonkey/mozilla/xpcom/threads/plevent.c 
line 597] 
	 _md_EventReceiverProc	[c:/builds/seamonkey/mozilla/xpcom/threads/plevent.c 
line 1385] 
	 USER32.dll + 0x4455 (0x77d44455)  
	 USER32.dll + 0x95d5 (0x77d495d5)  
	 nsAppShellService::Run
[c:/builds/seamonkey/mozilla/xpfe/appshell/src/nsAppShellService.cpp  line 480] 
	 main1	[c:/builds/seamonkey/mozilla/xpfe/bootstrap/nsAppRunner.cpp  line 1285] 
	 main	[c:/builds/seamonkey/mozilla/xpfe/bootstrap/nsAppRunner.cpp  line 1643] 
	 WinMain	[c:/builds/seamonkey/mozilla/xpfe/bootstrap/nsAppRunner.cpp  line 1664] 
	 WinMainCRTStartup()  
	 kernel32.dll + 0x214c7 (0x77e814c7)   
 
     (18027937)	Comments: Installed the latest build of Mozilla and tried to
start is.....
     (18026393)	URL: http://presario.my.yahoo.com/
     (18026393)	Comments: Gave the nightly build another shot and tried to
launch manually. 
     (18026381)	URL: http://presario.my.yahoo.com/
     (18026381)	Comments: Had just downloaded a nightly build and it was
launching automatically when it stopped and the feedback agent appeared. 
     (18026337)	Comments: Installing the latest nightly release (12/03/2003)
     (18022407)	Comments: Had just installed nightly build and started for first
time.
     (18021786)	Comments: first startup after download & install  - instant crash.

Comment 1

[Jay Patel [:jay]]

Cc'ing some folks from bug 196094.  The crash source line points to timeless'
checkin on 3/4:

1.97 <[e-mail]> 04 Mar 2003 18:35
Bug 190020 GetResource should take AUTF8String
patch by [e-mail] r=cls sr=alec

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

we were talking a bit about this on irc, I think dbradley came to the conlusion
that the string was getting incorrectly treated as string rather than nsACString
or so, and it was probably due to wrong .xpt files (outdated or from a branch)

Comment 3

[David Bradley]

This really shouldn't be happening, though. The .autoreg cleared most of that
up. Unless someone actually old xpt files or something, or otherwise
misinstalled. Also realize that 1 user accounts for about 8 or so incidents.
There's probably just a few users out there that have screwed up installs or
something.

Comment 4

[Alec Flett]

whats wierd is that this JUST started showing up on the 3-12 builds.

Comment 5

[David Bradley]

Yes, and that made me question the XBL patch that went in, but I'm not sure how
that could have created such a problem.

Comment 6

[Brian Ryner (not reading)]

There are a couple of ways that the XBL patch could be related:

a) it's trashing memory in a way that tickles this function
b) the XBL crasher essentially blocked anyone who had multiple profiles from
starting up builds from 3/7 through 3/11.  Perhaps it was masking this separate
crash which was introduced during that timeframe?

Comment 7

[Doug Turner (:dougt)]

is this a dup?

http://bugzilla.mozilla.org/show_bug.cgi?id=197692

Comment 8

[Asa Dotzler [:asa]]

100% reproducible steps for me on winXP
1. install 1.3 installer build. 
2. install 1.4a nightly from 0317 (and possibly earlier, haven't tested yet) on
top of 1.3 without uninstalling 1.3 first.

results: crash on launch. 

If I first uninstall 1.3 and then install 1.4a nightly I get no crash. That
works consistently. If these are the common steps to reproduce then this should
probably block 1.4a.

Comment 9

[Asa Dotzler [:asa]]

Doug, if bug 197692 was fixed with cls' checkin at 03/17/2003 01:22
seawood%netscape.com 	mozilla/ config/ Moz/ Milestone.pm 	1.2 	2/0  	Attempt to
fix smoketest blocker by removing extraneous ^M from GRE_BUILD_ID then this
isn't a duplicate because I can still reproduce with this morning's 8am windows
build. 

Comment 10

[Boris Zbarsky [:bzbarsky]]

Asa, if those are the steps to reproduce then this is an Installer bug, no? 
Does indeed sound like an xpt file is not getting properly cleaned up....

Comment 11

[timeless]

blame gre. <rant class="standard-gre"/>

the following dlls were removed by the 1.4 installer:
imgicon.dll
oji.dll
impComm4xMail.dll
imglib2.dll
gkparser.dll
uconv.dll
rdf.dll
gkwidget.dll
i18n.dll
nsLDAPPrefService.js
wallet.dll
urildr.dll
shistory.dll
msgdb.dll
xmlextras.dll
nsXmlRpcClient.js
impOutlk.dll
mailview.dll
mime.dll
bayesflt.dll
importOE.dll
mdn-service.js
smime-service.js
nsSetDefaultMail.js
msgsmime.dll
msgcompo.dll
import.dll
msgmdn.dll
mail.xpt
msgbase.dll
msgimap.dll
msgMapi.dll
msgnews.dll
inspector.xpt
inspector.dll
fullsoft.dll
qfaservices.xpt
master.ini
xpti.dat
compreg.dat

Here is the list of files surviving:
imgicon.xpt     03/12/2003      06:13a  267
oji.xpt 03/12/2003      06:09a  519
imglib2.xpt     03/12/2003      06:12a  2,201
uconv.xpt       03/12/2003      06:00a  1,104
rdf.xpt 03/12/2003      06:10a  4,343
wallet.xpt      03/12/2003      06:57a  1,248
shistory.xpt    03/12/2003      06:53a  2,231
xmlextras.xpt   03/12/2003      06:58a  1,335
inspector.xpt   03/17/2003      05:28a  3,600

From that list, the following items were migrated to the gre and therefore
should have been deleted by the gre installer:
mozilla.org\GRE\1.4a_2003031708\components\imgicon.xpt
mozilla.org\GRE\1.4a_2003031708\components\oji.xpt
mozilla.org\GRE\1.4a_2003031708\components\imglib2.xpt
mozilla.org\GRE\1.4a_2003031708\components\uconv.xpt
mozilla.org\GRE\1.4a_2003031708\components\rdf.xpt
mozilla.org\GRE\1.4a_2003031708\components\wallet.xpt
mozilla.org\GRE\1.4a_2003031708\components\shistory.xpt
mozilla.org\GRE\1.4a_2003031708\components\xmlextras.xpt

I have on idea what happened to Inspector, i'll shoot someone about that later.

Comment 12

[Alec Flett]

ah! so we need just to add those .xpt files to the list of files in the
deleteThisFile list in browser.jst:
http://lxr.mozilla.org/seamonkey/source/xpinstall/packager/windows/browser.jst#375

timeless: just to double check, your list is a comprehensive list? are there
more we should consider?

Comment 13

[timeless]

oops, here are some more:
mozilla.org\GRE\1.4a_2003031708\components\profile.xpt
mozilla.org\GRE\1.4a_2003031708\components\necko_cookie.xpt
mozilla.org\GRE\1.4a_2003031708\components\appshell.xpt
mozilla.org\GRE\1.4a_2003031708\components\caps.xpt
mozilla.org\GRE\1.4a_2003031708\components\pipboot.xpt
mozilla.org\GRE\1.4a_2003031708\components\necko.xpt
mozilla.org\GRE\1.4a_2003031708\components\editor.xpt
mozilla.org\GRE\1.4a_2003031708\components\pipnss.xpt
mozilla.org\GRE\1.4a_2003031708\components\chrome.xpt

Comment 14

[timeless]

Attachment: fix browser.jst

Comment 15

[timeless]

Comment on attachment 117628 [details] [diff] [review]
fix browser.jst

some of the changes here are sorting, sorry about that but i wanted some
sanity.

Comment 16

[Alec Flett]

Comment on attachment 117628 [details] [diff] [review]
fix browser.jst

no please don't resort that. just add the new files. put them next to the DLLs
if you want but I want the order the way it was because its a simple way to
track dll consolidation.

Comment 17

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch without resorting

Comment 18

[Sean Su]

Comment on attachment 117728 [details] [diff] [review]
patch without resorting

r=ssu

Comment 19

[Alec Flett]

Comment on attachment 117728 [details] [diff] [review]
patch without resorting

thanks, this looks great!
sr=alecf

Comment 20

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Fix (hopefully) checked in, 2003-03-19 11:15 PST.

Comment 21

[Sean Su]

by the way, I applied the same patch to the ns tree because the ns tree has it's
own installer as compared to mozilla.

Comment 22

[timeless]

*** Bug 198467 has been marked as a duplicate of this bug. ***

Comment 23

[Grace Bush]

verified