1972421 - Add OMC Highlight to Follow Button in Sections Layout

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement)

Description

[Maxx Crawford [:maxx]]

See Figma: https://www.figma.com/design/VdghooQZTLiXYO8hF5pAuS/Feed?node-id=10707-461826&m=dev

Comment 1

[Maxx Crawford [:maxx]]

Attachment: Bug 1972421 - Add strings for Follow Section Button Highlight r?#home-newtab-reviewers

Comment 2

[Maxx Crawford [:maxx]]

Attachment: Bug 1972421 - Add Follow Section Button Highlight message component r?#home-newtab-reviewers

Comment 3

[Maxx Crawford [:maxx]]

Attachment: Bug 1972421 - Add test coverage for FollowSectionButtonHighlight component r?#home-newtab-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7f5ac75dccdb
https://hg.mozilla.org/integration/autoland/rev/6bb8141ea1a0
Add strings for Follow Section Button Highlight r=home-newtab-reviewers,fluent-reviewers,bolsson,npypchenko,nbarrett
https://github.com/mozilla-firefox/firefox/commit/8977887259e8
https://hg.mozilla.org/integration/autoland/rev/3eab13ee94ac
Add Follow Section Button Highlight message component r=home-newtab-reviewers,npypchenko
https://github.com/mozilla-firefox/firefox/commit/a9a971a6ef37
https://hg.mozilla.org/integration/autoland/rev/8b27e915ed89
Add test coverage for FollowSectionButtonHighlight component r=home-newtab-reviewers,npypchenko

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/6bb8141ea1a0
https://hg.mozilla.org/mozilla-central/rev/3eab13ee94ac
https://hg.mozilla.org/mozilla-central/rev/8b27e915ed89

Comment 6

[Nathan Barrett [:nbarrett]]

Attachment: Bug 1972421 - Add strings for Follow Section Button Highlight r?#home-newtab-reviewers

Original Revision: https://phabricator.services.mozilla.com/D254300

Comment 7

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: None
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: n/a
• Risk associated with taking this patch: low risk
• Explanation of risk level: Updates the strings used for a newtab callout
• String changes made/needed: newtab-section-follow-highlight-title = Fine-tune your feed newtab-section-follow-highlight-subtitle = Follow your interests to see more of what you like.
• Is Android affected?: no

Comment 8

[Nathan Barrett [:nbarrett]]

Attachment: Bug 1972421 - Add strings for Follow Section Button Highlight r?#home-newtab-reviewers

Original Revision: https://phabricator.services.mozilla.com/D254300

Comment 9

[Nathan Barrett [:nbarrett]]

Attachment: Bug 1972421 - Add Follow Section Button Highlight message component r?#home-newtab-reviewers

Original Revision: https://phabricator.services.mozilla.com/D254301

Comment 10

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Will not be able to display follow highlight
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: et the following prefs to true: browser.newtabpage.activity-stream.asrouter.devtoolsEnabled browser.newtabpage.activity-stream.discoverystream.sections.personalization.enabled browser.newtabpage.activity-stream.discoverystream.sections.enabled Additional notes: You'll want to open the Browser Console to see any errors. Start with a fresh profile if possible Test scenarios: Interacting with the topic selection modal Open new tab Expected: The recommended stories feed should be in the "Section" layout with a "Follow" button at the top-right of each section Expected: There should be NO callout visible Open about:asrouter Cmd+F/Scroll down to TEST_NEWTAB_MESSAGE Replace "DownloadMobilePromoHighlight" with "FollowSectionButtonHighlight" in this box and click "MODIFY" button Open a new new tab Expected: The Follow Button callout should be visible only on second section Additional edge cases / testing: If you click the "X" of the highlight, the message should show as BLOCKED in about:asrouter If you are already following one store, this message should not be visible (regardless of message)
• Risk associated with taking this patch: Low
• Explanation of risk level: Will not affect other code, just enables us to use this new messaging
• String changes made/needed: n/a
• Is Android affected?: no

Comment 11

[Nathan Barrett [:nbarrett]]

Attachment: Bug 1972421 - Add strings for Follow Section Button Highlight r?#home-newtab-reviewers

Original Revision: https://phabricator.services.mozilla.com/D254300

Comment 12

[Nathan Barrett [:nbarrett]]

Attachment: Bug 1972421 - Add Follow Section Button Highlight message component r?#home-newtab-reviewers

Original Revision: https://phabricator.services.mozilla.com/D254301

Comment 13

[Nathan Barrett [:nbarrett]]

Attachment: Bug 1972421 - Add test coverage for FollowSectionButtonHighlight component r?#home-newtab-reviewers

Original Revision: https://phabricator.services.mozilla.com/D254302

Comment 14

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: none
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: n/a
• Risk associated with taking this patch: none
• Explanation of risk level: Adds tests for https://phabricator.services.mozilla.com/D254883
• String changes made/needed: n/a
• Is Android affected?: no

Comment 15

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/65d7087a5a19
https://hg.mozilla.org/releases/mozilla-beta/rev/8b3d1804424d

Comment 16

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/f740469e3845
https://hg.mozilla.org/releases/mozilla-beta/rev/f44110f7419c

Comment 17

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/96ddbfd442ba
https://hg.mozilla.org/releases/mozilla-beta/rev/bee32e6be6fe

Comment 18

[Marius Coman [:mcoman], Ecosystem QA]

This enhancement was part of the work done on QA-4103 for which we already sent a testing report via email. Considering this, I am marking it as Verified - Fixed.