1972486 - WebGPU: release on stable on Windows 🎉

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, enhancement, P1)

Comment 1

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 1972486 - chore(webgpu): enable on Windows by default r=#webgpu-reviewers!,#webidl!

Comment 2

[Pascal Chevrel:pascalc]

(will require an addition to our 141 release notes)

Comment 3

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1972486 - Enable WebGPU on Windows by default r=#webgpu-reviewers!,#webidl!

Applying D253924 on top of bug 1972918.

Comment 4

[Kagami Rosylight [:saschanaz] (they/them)]

BTW we still have known crashes in WPT, are they somehow okay to be ignored for now? Otherwise I wonder it should be a release blocker. https://searchfox.org/mozilla-central/search?q=expected%3A+CRASH&path=webgpu&case=true&regexp=false

And also, as I just pinged you in Matrix, do we want to ship webgpu for workers too here?

Comment 5

[Kagami Rosylight [:saschanaz] (they/them)]

Look who is back!

Comment 6

[Erich Gubler [:ErichDonGubler] (he/him)]

Answering for Jim: Yes, we definitely want to ship support for all worker types minus service workers, which do not yet have CTS runs (see bug 1942431 and its dependencies).

Comment 7

[Erich Gubler [:ErichDonGubler] (he/him)]

(In reply to Kagami Rosylight [:saschanaz] (they/them) from comment #4)

BTW we still have known crashes in WPT, are they somehow okay to be ignored for now? Otherwise I wonder it should be a release blocker. https://searchfox.org/mozilla-central/search?q=expected%3A+CRASH&path=webgpu&case=true&regexp=false

These are risks we've accepted for now with shipping. Our team is focusing on removing any CRASHes we think are dangerous to end users for the next iteration, with uplifts to Beta being our current plan. Most of these crashes are panics on conditions not being validated in earlier parts of the WebGPU API but which are standardized to be checked, but not exploitable. Some others are not panics, and we need a fast follow on these.

Comment 8

[Kagami Rosylight [:saschanaz] (they/them)]

(In reply to Erich Gubler [:ErichDonGubler] (he/him) from comment #6)

Answering for Jim: Yes, we definitely want to ship support for all worker types minus service workers, which do not yet have CTS runs (see bug 1942431 and its dependencies).

minus service worker sounds like we need an extra pref, because the current pref covers all workers?

(In reply to Erich Gubler [:ErichDonGubler] (he/him) from comment #7)

These are risks we've accepted for now with shipping. Our team is focusing on removing any CRASHes we think are dangerous to end users for the next iteration, with uplifts to Beta being our current plan. Most of these crashes are panics on conditions not being validated in earlier parts of the WebGPU API but which are standardized to be checked, but not exploitable. Some others are not panics, and we need a fast follow on these.

I guess that decision is based on crash stats on beta/nightly, right?

Comment 9

[Erich Gubler [:ErichDonGubler] (he/him)]

:saschanaz: I'm moving conversation from here into D253924; let's keep things in one place, and not fragmented between two patches and this bug's feed. 😅

Comment 10

[Erich Gubler [:ErichDonGubler] (he/him)]

I guess that decision is based on crash stats on beta/nightly, right?

So far, yes!

Comment 11

[Erich Gubler [:ErichDonGubler] (he/him)]

I guess that decision is based on crash stats on beta/nightly, right?

My position on this is further explained in the patch.

Comment 12

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 1972486 - chore(webgpu)!: narrow `dom.webgpu.workers.enabled` to `….service-workers.enabled` r=#webgpu-reviewers!

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5b78b57d86b3
https://hg.mozilla.org/integration/autoland/rev/b4a18aa945d7
chore(webgpu)!: narrow `dom.webgpu.workers.enabled` to `….service-workers.enabled` r=webgpu-reviewers,saschanaz,jimb

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1444ad724640
https://hg.mozilla.org/integration/autoland/rev/2c8ead2b3d14
Revert "Bug 1972486 - chore(webgpu)!: narrow `dom.webgpu.workers.enabled` to `….service-workers.enabled` r=webgpu-reviewers,saschanaz,jimb" for causing mochitets failures in browser_aboutURLs.js.

Comment 15

[Serban Stanca [:SerbanS]]

Reverted this because it was causing mochitets failures in browser_aboutURLs.js.

• Revert link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/contextualidentity/test/browser/browser_aboutURLs.js | A promise chain failed to handle a rejection: Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getBoolPref] - stack: refreshPage@chrome://global/content/aboutInference.js:609:20

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a364f4fac9fc
https://hg.mozilla.org/integration/autoland/rev/b42fff40af34
chore(webgpu)!: narrow `dom.webgpu.workers.enabled` to `….service-workers.enabled` r=webgpu-reviewers,saschanaz,jimb
https://github.com/mozilla-firefox/firefox/commit/b805bf25d159
https://hg.mozilla.org/integration/autoland/rev/f540263c97a2
chore(webgpu): enable on Windows by default r=webgpu-reviewers,webidl,smaug,jimb

Comment 17

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b42fff40af34
https://hg.mozilla.org/mozilla-central/rev/f540263c97a2

Comment 18

[Erich Gubler [:ErichDonGubler] (he/him)]

Next step: uplift to Beta! 😀

Comment 19

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 1972486 - chore(webgpu)!: narrow `dom.webgpu.workers.enabled` to `….service-workers.enabled` r=#webgpu-reviewers!

Original Revision: https://phabricator.services.mozilla.com/D255381

Comment 20

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 1972486 - chore(webgpu): release on stable on Windows with narrowed service worker pref. r=#webgpu-reviewers

Make IDL available in all contexts. Limit adapters to content, dedicated
workers, and shared workers; basically everything but service workers,
which is blocked on bug 1942431.

Original Revision: https://phabricator.services.mozilla.com/D253924

Comment 21

[Jim Blandy :jimb]

Attachment: Bug 1972486 - chore(webgpu): release on stable on Windows with narrowed service worker pref. r=#webgpu-reviewers

Aggregates D255381 and D253924 for uplift to Beta.

Original Revision: https://phabricator.services.mozilla.com/D255649

Comment 22

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: WebGPU will not ship in Fx141
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: none
• Risk associated with taking this patch: WebGPU is a new DOM API.
• Explanation of risk level: low; it's been in Nightly for years
• String changes made/needed: none
• Is Android affected?: no

Comment 23

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/f3648872934c
https://hg.mozilla.org/releases/mozilla-beta/rev/6e9cda61d146

Comment 24

[Pascal Chevrel:pascalc]

Could we get a release note for this change? Thanks
https://wiki.mozilla.org/Release_Management/Release_Notes_Nomination#Nomination_in_Bugzilla

Comment 25

[Erich Gubler [:ErichDonGubler] (he/him)]

Jim has stated in team meetings that he intends to be the one to write a release note for this.

Comment 26

[Hamish Willee]

FF141 MDN work for this can be tracked in https://github.com/mdn/content/issues/40473