1972538 - Remove from taskbar button (pageAction) has the same tooltip as the add to taskbar button (pageAction)

Status: VERIFIED FIXED

(Firefox :: Shell Integration, defect)

Description

[Alex Cornestean]

Attachment: 2025-06-17_14h18_52.png

Affected Version:
Nightly - 141.0a1/20250616214059

Description:
The remove from taskbar button (pageAction) tooltip states “Add to taskbar” instead of the action is actually performs.

Steps to reproduce:

1. Open https://www.wikipedia.org/ in a Taskbar Tabs window
2. In the Taskbar Tabs window, hover over the pageAction
3. Notice the button (pageAction) states “Add to taskbar”

Actual results:
The (pageAction) in a Taskbar Tabs window states “Add to taskbar”

Expected results:
The (pageAction) in a Taskbar Tabs window should state the correct action it actually performs i.e. remove from taskbar

Comment 1

[Duncan McIntosh [:dmcintosh]]

Attachment: Bug 1972538 - Match Taskbar Tab page action tooltips to the type of window. r=nrishel,#fluent-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ed3127d2bb88
https://hg.mozilla.org/integration/autoland/rev/a96c9d716438
Match Taskbar Tab page action tooltips to the type of window. r=nrishel,fluent-reviewers,bolsson

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/a96c9d716438

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 5

[Alex Cornestean]

Verified as Fixed. Tested on the latest Nightly (143.0a1/20250803215053).

The remove from taskbar pageAction tooltip now states “Remove tab from taskbar” while the add to taskbar pageAction tooltip now states ”Add tab to taskbar”.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:dmcintosh, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox142 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Duncan McIntosh [:dmcintosh]]

Probably not worth uplifting, as it's a minor detail.