1972586 - Choose SIPHash based on CPU Arch

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, enhancement)

Description

[Tom Ritter [:tjr] (OOTO until April)]

Testing has shown that (surprise) SIPHash is faster than operating on shorter byte arrays or when the processor doesn't have SHA-256 instructions.

Comment 1

[Tom Ritter [:tjr] (OOTO until April)]

Attachment: Bug 1972586: Add detection for SHA instructions r?glandium

Comment 2

[Tom Ritter [:tjr] (OOTO until April)]

Attachment: Bug 1972586: Choose SIPHash when it's probably going to be faster than HMAC r?timhuang

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f17d9ab463d0
https://hg.mozilla.org/integration/autoland/rev/875879facfb1
Add detection for SHA instructions r=glandium
https://github.com/mozilla-firefox/firefox/commit/dda9e252e268
https://hg.mozilla.org/integration/autoland/rev/0c2863583555
Choose SIPHash when it's probably going to be faster than HMAC r=timhuang

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/875879facfb1
https://hg.mozilla.org/mozilla-central/rev/0c2863583555