Context menu for userlist doesn't toggle both ways for sort and show modes in cZ
Categories
(SeaMonkey :: Chat, defect)
Tracking
(seamonkey2.53? affected)
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
(Regression)
Details
(Keywords: regression, Whiteboard: SM2.53.22)
Attachments
(1 file)
|
920 bytes,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
Toggling the user sort by mode and show mode symbol doesn't work properly, it only lets you toggle one way. Works fine through cZ preferences.
The issue is that checked is an attribute not a property of a menuitem.
[Approval Request Comment]
Regression caused by (bug #): 1957763 and 1961382
User impact if declined: context toggle doesn't work
Testing completed (on m-c, etc.): 2.53.22pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
|
||
Updated•2 months ago
|
|
|
||
Comment 2•2 months ago
|
||
Comment on attachment 9495376 [details] [diff] [review]
1972724-irc-toggle-context-fix-25322.patch
LGTM r/a+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/f563ae4e52e6
Context menu for userlist doesn't toggle both ways for sort and show modes in cZ. r=frg DONTBUILD
Description
•