197274 - improve text of "enable automatic image resizing" pref

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, enhancement, P3)

Description

[Jesse Ruderman]

I see two problems with the text "Enable automatic image resizing":
1. It starts with "Enable", which doesn't add any information.  (Consider
"Enable pop-up blocking" vs. "Block pop-up windows".)
2. It gives the name of a feature, and the name of the feature doesn't give
enough details about what the feature does.

I suggest:

"Resize images that don't fit in the browser window"
or
"Automatically scale down large images"

Comment 1

[Boris Zbarsky [:bzbarsky]]

Wrong component....

Comment 2

[Samir Gehani]

Nav triage team: nsbeta1+/adt3

Robin, could you comment with an appropriate wording change?

Jesse, would you be interested in helping by fixing this?  If so, feel free to
assign the bug to yourself.  Thanks.

Comment 3

[robinf]

>"Resize images that don't fit in the browser window"

Agree.

Comment 4

[Alex Bishop]

> "Resize images that don't fit in the browser window"

Wouldn't "Resize images that are too large to fit in the browser window" be better?

Comment 5

[Alex Bishop]

Or maybe just "Resize large images to fit in the browser window".

Comment 6

[robinf]

>Or maybe just "Resize large images to fit in the browser window".

Yes, that's better. Thanks!

Comment 7

[Jesse Ruderman]

I like Alex's text, "Resize large images to fit in the browser window".

Comment 8

[Alex Bishop]

Attachment: Change "Enable automatic image resizing" to "Resize large images to fit in the browser window"

This should do it. Access key ('r') left unchanged.

Comment 9

[Alex Bishop]

Comment on attachment 121383 [details] [diff] [review]
Change "Enable automatic image resizing" to "Resize large images to fit in the browser window"

Rquesting super-review from Alec Flett.

Really simple patch, just changes wording of "Enable automatic image resizing"
checkbox to "Resize large images to fit in the browser window". Patch has
review from varga, wording approved by robinf.

Comment 10

[Alec Flett]

Comment on attachment 121383 [details] [diff] [review]
Change "Enable automatic image resizing" to "Resize large images to fit in the browser window"

sr=alecf - good to see

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

>This should do it. Access key ('r') left unchanged.

That's bad, you should have changed it to 'R'

Comment 12

[Alex Bishop]

>> This should do it. Access key ('r') left unchanged.
>
> That's bad, you should have changed it to 'R'

OK, I'll update the patch. Out of interest, why is this change necessary?

Comment 13

[Alex Bishop]

Attachment: Patch that also capitalises the access key

Comment 14

[Christian :Biesinger (don't email me, ping me on IRC)]

A lowercase 'r' will first search for a lowercase r in the label and underline
that (if that would fail, it would use the uppercase R). However, as the new
string starts with R, it looks much better to underline the uppercase R, for
which you have to use an uppercase R accesskey.

Comment 15

[Jan Varga [:janv]]

Comment on attachment 121745 [details] [diff] [review]
Patch that also capitalises the access key

carrying over r/sr and requesting an approval

Comment 16

[(not reading, please use [e-mail] instead)]

Comment on attachment 121745 [details] [diff] [review]
Patch that also capitalises the access key

a=sspitzer

Comment 17

[Jan Varga [:janv]]

checked in, thanks for the patch