Closed Bug 197274 Opened 20 years ago Closed 20 years ago

improve text of "enable automatic image resizing" pref

Categories

(SeaMonkey :: UI Design, enhancement, P3)

x86
All
enhancement

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.4beta

People

(Reporter: jruderman, Assigned: janv)

Details

(Keywords: helpwanted, Whiteboard: [adt3] [UI])

Attachments

(1 file, 1 obsolete file)

I see two problems with the text "Enable automatic image resizing":
1. It starts with "Enable", which doesn't add any information.  (Consider
"Enable pop-up blocking" vs. "Block pop-up windows".)
2. It gives the name of a feature, and the name of the feature doesn't give
enough details about what the feature does.

I suggest:

"Resize images that don't fit in the browser window"
or
"Automatically scale down large images"
Keywords: nsbeta1
Wrong component....
Component: Preferences → XP Apps
QA Contact: sairuh → petersen
Nav triage team: nsbeta1+/adt3

Robin, could you comment with an appropriate wording change?

Jesse, would you be interested in helping by fixing this?  If so, feel free to
assign the bug to yourself.  Thanks.
Keywords: nsbeta1helpwanted, nsbeta1+
Whiteboard: [adt3]
OS: Windows XP → All
Priority: -- → P3
Target Milestone: --- → mozilla1.4beta
>"Resize images that don't fit in the browser window"

Agree.
> "Resize images that don't fit in the browser window"

Wouldn't "Resize images that are too large to fit in the browser window" be better?
Or maybe just "Resize large images to fit in the browser window".
>Or maybe just "Resize large images to fit in the browser window".

Yes, that's better. Thanks!
I like Alex's text, "Resize large images to fit in the browser window".
Whiteboard: [adt3] → [adt3] [UI]
This should do it. Access key ('r') left unchanged.
Attachment #121383 - Flags: review+
Comment on attachment 121383 [details] [diff] [review]
Change "Enable automatic image resizing" to "Resize large images to fit in the browser window"

Rquesting super-review from Alec Flett.

Really simple patch, just changes wording of "Enable automatic image resizing"
checkbox to "Resize large images to fit in the browser window". Patch has
review from varga, wording approved by robinf.
Attachment #121383 - Flags: superreview?(alecf)
Comment on attachment 121383 [details] [diff] [review]
Change "Enable automatic image resizing" to "Resize large images to fit in the browser window"

sr=alecf - good to see
Attachment #121383 - Flags: superreview?(alecf) → superreview+
>This should do it. Access key ('r') left unchanged.

That's bad, you should have changed it to 'R'
>> This should do it. Access key ('r') left unchanged.
>
> That's bad, you should have changed it to 'R'

OK, I'll update the patch. Out of interest, why is this change necessary?
Attachment #121383 - Attachment is obsolete: true
A lowercase 'r' will first search for a lowercase r in the label and underline
that (if that would fail, it would use the uppercase R). However, as the new
string starts with R, it looks much better to underline the uppercase R, for
which you have to use an uppercase R accesskey.
Comment on attachment 121745 [details] [diff] [review]
Patch that also capitalises the access key

carrying over r/sr and requesting an approval
Attachment #121745 - Flags: superreview+
Attachment #121745 - Flags: review+
Attachment #121745 - Flags: approval1.4b?
Comment on attachment 121745 [details] [diff] [review]
Patch that also capitalises the access key

a=sspitzer
Attachment #121745 - Flags: approval1.4b? → approval1.4b+
checked in, thanks for the patch
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Product: Core → Mozilla Application Suite
You need to log in before you can comment on or make changes to this bug.